Skip to content

chore: move design-tokens into merged-packages as part of migration process#100

Merged
georgewrmarshall merged 168 commits into
mainfrom
migrate-design-tokens
Nov 12, 2024
Merged

chore: move design-tokens into merged-packages as part of migration process#100
georgewrmarshall merged 168 commits into
mainfrom
migrate-design-tokens

Conversation

@georgewrmarshall

Copy link
Copy Markdown
Contributor

Duplicate of #92 with updated main branch

Description

This PR follows [PR#6] 1. Migrate the source repo's git history into the merged-packages/ temporary directory in metamask design system as part of the package migration process guide. This step migrates the Git history of the design-tokens repository into the metamask-design-system monorepo, placing all contents under the merged-packages/design-tokens directory.

Example PR in core

Related issues

Partly fixes: #88

Manual testing steps

  1. Check the contents under merged-packages/design-tokens in the metamask-design-system repository to ensure the file structure aligns with the original design-tokens repository.
  2. Verify that the commit history within merged-packages/design-tokens accurately preserves previous design-tokens commits.
  3. Confirm successful integration within the monorepo and that no errors are introduced.

Pre-merge author checklist

  • Verified git-filter-repo installation and migration process.
  • Confirmed all design-tokens files are correctly moved to merged-packages/design-tokens.
  • Checked that the full commit history for design-tokens is retained.
  • Followed MetaMask Coding Standards.
  • Set PR status appropriately.

Pre-merge reviewer checklist

  • Confirmed that all design-tokens files appear in merged-packages/design-tokens with the correct structure.
  • Verified the commit history for design-tokens is intact and accurately reflects the original repository.
  • Ensured this PR meets all acceptance criteria.

Cal-L and others added 30 commits January 19, 2022 14:34
Pushing new tokens from Figma
* 1.0.0

* Update CHANGELOG.md

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Erik Marks <25517051+rekmarks@users.noreply.github.com>
* Add issue template

* Prettify issue template
* Adding css stylesheet contaiing color design tokens

* Adding css path to build

Co-authored-by: Cal Leung <cleun007@gmail.com>
Co-authored-by: github-actions <github-actions@github.com>
* Updating some token descriptions that were wrong

* Adding HEX values to descriptions and updating primary in dark mode

* Updating token descriptions for brand colors

* Adding secondary tokens to light theme

* Adding storybook and adding initial design token documentation

* Clean up

* Updating some linting issues

* Updating scripts

* Adding secondary colors to dark and updating muted for both light and dark

* Updating all muted values

* Adding storybook and adding initial design token documentation

* Clean up

* Updating some linting issues

* Updating all muted values

* Swapping background default and alternative in dark mode and updating border color to be slightly less darker

* Skip lib check

* Add license to package.json

* Updates to tokens and docs

* Restoring token json token from main

* Try to fix test but updating text

* Fix build error

Co-authored-by: Cal Leung <cleun007@gmail.com>
* 1.2.0

* Update change log

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: Cal Leung <cleun007@gmail.com>
* 1.3.0

* Updating category in changelog

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
* updated dark-theme to hex (w alpha)

* Update src/figma/tokens.json

* Update src/figma/tokens.json

* Update src/figma/tokens.json

* Update src/figma/tokens.json

* Update src/figma/tokens.json

* Update src/figma/tokens.json

* updated light-theme to hex (w alpha)

* updated blue400 to correct hex

* Changed all color to HEX value

* Converting CSS variables

* Generating light theme hex value updates

* generating js dark theme tokens

* Generating dark css

* Fixing secondary default

* Fixing border default description

Co-authored-by: Hiro M <55973039+Akatori-Design@users.noreply.github.com>
georgewrmarshall and others added 15 commits May 29, 2024 14:21
* chore: upgrading storybook to 8.1.3

* chore: upgrading storybook to v8.1.4
* chore: updated css variables based on updated json

* refactor: updated css variable namings

* feat: added deprecated css files

* refactor: updated migration changelist based on comments

* refactor: updated migration doc

* refactor: updated title for css part in migration doc

* refactor: simplified deprecated tokens

* refactor: removed deprecated colors and updated migration doc

* refactor: updated css naming

* refactor: nit changes

* feat: readded overlay inverse back to css variables

* docs: updating migrations doc layout

* chore: reverting css import order

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
* feat: updated js tokens based on updated json

* refactor: updated migration doc

* feat: added deprecated tokens

* refactor: removed deprecated tokens and updated tests

* refactor: updated migration doc

* refactor: removed addition language in migration doc

* feat: readded overlay inverse back in js tokens

* docs: updating migration docs to include js updates

* fix: adding removed heading back

---------

Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
* 4.0.0

* chore: updating changelog

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
… Token JSON (#719)

* feat: added tests for css variables

* refactor: removed lint ignore
* feat: add dark classname

* add light class
* chore: aligning dependencies with the metamask-design-system

* chore: aligning dependencies with design-system-react
* 4.1.0

* chore: updating changelog

---------

Co-authored-by: github-actions <github-actions@github.com>
Co-authored-by: georgewrmarshall <george.marshall@consensys.net>
@socket-security

socket-security Bot commented Nov 12, 2024

Copy link
Copy Markdown

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@inquirer/confirm@0.0.14-alpha.0 None 0 3.75 kB sboudrias
npm/@inquirer/core@0.0.15-alpha.0 None +2 36.4 kB sboudrias
npm/@inquirer/input@0.0.15-alpha.0 None 0 7.33 kB sboudrias
npm/@lavamoat/preinstall-always-fail@2.1.0 None 0 3.53 kB lmbot
npm/@parcel/watcher-android-arm64@2.5.0 None 0 410 kB devongovett
npm/@parcel/watcher-darwin-arm64@2.5.0 None 0 344 kB devongovett
npm/@parcel/watcher-darwin-x64@2.5.0 None 0 344 kB devongovett
npm/@parcel/watcher-freebsd-x64@2.5.0 None 0 513 kB devongovett
npm/@parcel/watcher-linux-arm-glibc@2.5.0 None 0 445 kB devongovett
npm/@parcel/watcher-linux-arm-musl@2.5.0 None 0 440 kB devongovett
npm/@parcel/watcher-linux-arm64-glibc@2.5.0 None 0 459 kB devongovett
npm/@parcel/watcher-linux-arm64-musl@2.5.0 None 0 472 kB devongovett
npm/@parcel/watcher-linux-x64-glibc@2.5.0 None 0 517 kB devongovett
npm/@parcel/watcher-linux-x64-musl@2.5.0 None 0 513 kB devongovett
npm/@parcel/watcher-win32-arm64@2.5.0 None 0 537 kB devongovett
npm/@parcel/watcher-win32-ia32@2.5.0 None 0 418 kB devongovett
npm/@parcel/watcher-win32-x64@2.5.0 None 0 516 kB devongovett
npm/@parcel/watcher@2.5.0 environment, shell 0 129 kB devongovett
npm/@rollup/rollup-android-arm-eabi@4.24.4 None 0 1.62 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-android-arm64@4.24.4 None 0 2.22 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-darwin-arm64@4.24.4 None 0 2.19 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-darwin-x64@4.24.4 None 0 2.38 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-freebsd-arm64@4.24.4 None 0 2.14 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-freebsd-x64@4.24.4 None 0 2.47 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-arm-gnueabihf@4.24.4 None 0 2.26 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-arm-musleabihf@4.24.4 None 0 2.25 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-arm64-gnu@4.24.4 None 0 2.22 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-arm64-musl@4.24.4 None 0 2.12 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-powerpc64le-gnu@4.24.4 None 0 2.76 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-riscv64-gnu@4.24.4 None 0 2.28 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-s390x-gnu@4.24.4 None 0 3.81 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-x64-gnu@4.24.4 None 0 2.51 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-linux-x64-musl@4.24.4 None 0 2.5 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-win32-arm64-msvc@4.24.4 None 0 2.75 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-win32-ia32-msvc@4.24.4 None 0 2.57 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@rollup/rollup-win32-x64-msvc@4.24.4 None 0 3.31 MB guybedford, lukastaegert, rich_harris, ...1 more
npm/@types/mdast@4.0.4 None 0 29.4 kB types
npm/@types/minimatch@5.1.2 None 0 12.5 kB types
npm/@types/node@22.9.0 None 0 2.27 MB types
npm/@types/unist@3.0.3 None 0 6.26 kB types
npm/@vitejs/plugin-react@4.3.3 None 0 38 kB vitebot
npm/bail@2.0.2 None 0 6.35 kB wooorm
npm/bundle-require@4.2.1 environment, filesystem, unsafe 0 25.3 kB egoist
npm/cac@6.7.14 None 0 81.8 kB egoist
npm/ccount@2.0.1 None 0 7.34 kB wooorm
npm/character-entities@2.0.2 None 0 44.6 kB wooorm
npm/chromatic@11.16.5 None 0 5.48 MB andrewortwein, chromatic-ci-bot, codykaup, ...6 more
npm/clean-css-cli@5.6.3 environment, filesystem 0 45.6 kB jakub.pawlowicz
npm/clean-css@5.3.3 environment, filesystem, network 0 493 kB jakub.pawlowicz
npm/cli-width@3.0.0 environment 0 11.5 kB knownasilya
npm/decode-named-character-reference@1.0.2 None 0 9 kB wooorm
npm/devlop@1.1.0 None 0 22 kB wooorm
npm/eslint-plugin-storybook@0.8.0 None +1 98.6 kB yannbf
npm/extend@3.0.2 None 0 23.5 kB ljharb
npm/immutable@4.3.7 None 0 682 kB leebyron
npm/jest-it-up@2.2.0 filesystem Transitive: environment, shell +1 183 kB rbardini
npm/joycon@3.1.1 environment, filesystem 0 14 kB egoist
npm/load-tsconfig@0.2.5 None 0 17.1 kB egoist
npm/lodash.sortby@4.7.0 None 0 75.8 kB jdalton
npm/longest-streak@3.1.0 None 0 7.66 kB wooorm
npm/markdown-table@3.0.4 None 0 26.1 kB wooorm
npm/mdast-util-find-and-replace@3.0.1 None +1 26.6 kB wooorm
npm/mdast-util-from-markdown@2.0.2 None 0 97.8 kB wooorm
npm/mdast-util-gfm-autolink-literal@2.0.1 None 0 21.7 kB kmck, wooorm
npm/mdast-util-gfm-footnote@2.0.0 None 0 21.4 kB wooorm
npm/mdast-util-gfm-strikethrough@2.0.0 None 0 17.8 kB wooorm
npm/mdast-util-gfm-table@2.0.0 None 0 30.9 kB wooorm
npm/mdast-util-gfm-task-list-item@2.0.0 None 0 18.3 kB wooorm
npm/mdast-util-gfm@3.0.0 None 0 21.1 kB wooorm
npm/mdast-util-phrasing@4.1.0 None 0 10 kB wooorm
npm/mdast-util-to-markdown@2.1.2 None 0 149 kB wooorm
npm/mdast-util-to-string@4.0.0 None 0 12.7 kB wooorm
npm/micromark-core-commonmark@2.0.1 None 0 293 kB wooorm
npm/micromark-extension-gfm-autolink-literal@2.1.0 None 0 65.4 kB wooorm
npm/micromark-extension-gfm-footnote@2.1.0 None 0 79.5 kB wooorm
npm/micromark-extension-gfm-strikethrough@2.1.0 None 0 27.6 kB wooorm
npm/micromark-extension-gfm-table@2.1.0 None 0 88.4 kB wooorm
npm/micromark-extension-gfm-tagfilter@2.0.0 None 0 12 kB wooorm
npm/micromark-extension-gfm-task-list-item@2.1.0 None 0 24.4 kB wooorm
npm/micromark-extension-gfm@3.0.0 None 0 20.3 kB wooorm
npm/micromark-factory-destination@2.0.0 None 0 19 kB wooorm
npm/micromark-factory-label@2.0.0 None 0 16.3 kB wooorm
npm/micromark-factory-space@2.0.0 None 0 12.2 kB wooorm
npm/micromark-factory-title@2.0.0 None 0 15.2 kB wooorm
npm/micromark-factory-whitespace@2.0.0 None 0 10.6 kB wooorm
npm/micromark-util-character@2.1.0 None 0 33.1 kB wooorm
npm/micromark-util-chunked@2.0.0 None 0 14.2 kB wooorm
npm/micromark-util-classify-character@2.0.0 None 0 9.72 kB wooorm
npm/micromark-util-combine-extensions@2.0.0 None 0 11 kB wooorm
npm/micromark-util-decode-numeric-character-reference@2.0.1 None 0 9.94 kB wooorm
npm/micromark-util-decode-string@2.0.0 None 0 9.28 kB wooorm
npm/micromark-util-encode@2.0.0 None 0 6.42 kB wooorm
npm/micromark-util-html-tag-name@2.0.0 None 0 9.01 kB wooorm
npm/micromark-util-normalize-identifier@2.0.0 None 0 10.7 kB wooorm
npm/micromark-util-resolve-all@2.0.0 None 0 9.08 kB wooorm
npm/micromark-util-sanitize-uri@2.0.0 None 0 16.1 kB wooorm
npm/micromark-util-subtokenize@2.0.1 None 0 51.1 kB wooorm
npm/micromark-util-symbol@2.0.0 None 0 37.5 kB wooorm
npm/micromark-util-types@2.0.0 None 0 36.7 kB wooorm
npm/micromark@4.0.0 None 0 202 kB wooorm
npm/mute-stream@0.0.8 None 0 6.51 kB isaacs
npm/node-addon-api@7.1.1 None 0 396 kB legendecas
npm/psl@1.10.0 None 0 532 kB lupomontero
npm/react-refresh@0.14.2 environment 0 58.7 kB react-bot
npm/remark-gfm@4.0.0 None 0 21.4 kB wooorm
npm/remark-parse@11.0.0 None 0 19.5 kB wooorm
npm/remark-stringify@11.0.0 None 0 19.6 kB wooorm
npm/requireindex@1.2.0 filesystem 0 6.62 kB stephenhandley
npm/rollup@3.29.5 None 0 2.52 MB eventualbuddha, lukastaegert, rich_harris, ...2 more
npm/run-async@2.4.1 None 0 6.6 kB sboudrias
npm/sass@1.80.6 Transitive: environment, filesystem +2 5.94 MB hcatlin, nex3, sassbot
npm/tree-kill@1.2.2 shell 0 7.82 kB wmhilton
npm/trough@2.2.0 None 0 22.9 kB wooorm
npm/tsup@7.2.0 environment, eval, filesystem Transitive: network, shell +27 209 MB egoist
npm/undici-types@6.19.8 None 0 84.2 kB matteo.collina
npm/unified@11.0.5 None 0 146 kB wooorm
npm/unist-util-is@6.0.0 None 0 27.1 kB wooorm
npm/unist-util-stringify-position@4.0.0 None 0 13.2 kB wooorm
npm/unist-util-visit-parents@6.0.1 None 0 32.9 kB wooorm
npm/unist-util-visit@5.0.0 None 0 28.5 kB wooorm
npm/vfile-message@4.0.2 None 0 22.3 kB wooorm
npm/vfile@6.0.3 None 0 122 kB wooorm
npm/vite@5.4.10 Transitive: environment, filesystem, network, shell +25 232 MB antfu, patak, soda, ...2 more
npm/zwitch@2.0.4 None 0 13.8 kB wooorm

View full report↗︎

@socket-security

socket-security Bot commented Nov 12, 2024

Copy link
Copy Markdown

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: npm/cli-width@3.0.0, npm/mute-stream@0.0.8, npm/run-async@2.4.1, npm/webidl-conversions@4.0.2, npm/whatwg-url@7.1.0, npm/extend@3.0.2, npm/@types/minimatch@5.1.2, npm/lodash.sortby@4.7.0, npm/tr46@1.0.1, npm/@esbuild/android-arm@0.18.20, npm/@esbuild/android-arm64@0.18.20, npm/@esbuild/android-x64@0.18.20, npm/@esbuild/darwin-arm64@0.18.20, npm/@esbuild/darwin-x64@0.18.20, npm/@esbuild/freebsd-arm64@0.18.20, npm/@esbuild/freebsd-x64@0.18.20, npm/@esbuild/linux-arm@0.18.20, npm/@esbuild/linux-arm64@0.18.20, npm/@esbuild/linux-ia32@0.18.20, npm/@esbuild/linux-loong64@0.18.20, npm/@esbuild/linux-mips64el@0.18.20, npm/@esbuild/linux-ppc64@0.18.20, npm/@esbuild/linux-riscv64@0.18.20, npm/@esbuild/linux-s390x@0.18.20, npm/@esbuild/linux-x64@0.18.20, npm/@esbuild/netbsd-x64@0.18.20, npm/@esbuild/openbsd-x64@0.18.20, npm/@esbuild/sunos-x64@0.18.20, npm/@esbuild/win32-arm64@0.18.20, npm/@esbuild/win32-ia32@0.18.20, npm/@esbuild/win32-x64@0.18.20, npm/bail@2.0.2, npm/ccount@2.0.1, npm/character-entities@2.0.2, npm/decode-named-character-reference@1.0.2, npm/longest-streak@3.1.0, npm/escape-string-regexp@5.0.0, npm/zwitch@2.0.4, npm/esbuild@0.18.20, npm/tree-kill@1.2.2, npm/joycon@3.1.1, npm/source-map@0.8.0-beta.0, npm/cac@6.7.14, npm/@storybook/csf@0.0.1, npm/requireindex@1.2.0, npm/devlop@1.1.0, npm/mdast-util-to-string@4.0.0, npm/micromark-factory-destination@2.0.0, npm/micromark-factory-label@2.0.0, npm/micromark-factory-space@2.0.0, npm/micromark-factory-title@2.0.0, npm/micromark-factory-whitespace@2.0.0, npm/micromark-util-chunked@2.0.0, npm/micromark-util-classify-character@2.0.0, npm/micromark-util-combine-extensions@2.0.0, npm/micromark-util-decode-string@2.0.0, npm/micromark-util-encode@2.0.0, npm/micromark-util-html-tag-name@2.0.0, npm/micromark-util-normalize-identifier@2.0.0, npm/micromark-util-resolve-all@2.0.0, npm/micromark-util-sanitize-uri@2.0.0, npm/micromark-util-symbol@2.0.0, npm/micromark-util-types@2.0.0, npm/micromark@4.0.0, npm/remark-parse@11.0.0, npm/remark-stringify@11.0.0, npm/unist-util-is@6.0.0, npm/unist-util-stringify-position@4.0.0, npm/unist-util-visit-parents@6.0.1, npm/unist-util-visit@5.0.0, npm/vfile-message@4.0.2, npm/jest-it-up@2.2.0, npm/@inquirer/confirm@0.0.14-alpha.0, npm/@inquirer/core@0.0.15-alpha.0, npm/@inquirer/input@0.0.15-alpha.0, npm/mdast-util-find-and-replace@3.0.1, npm/mdast-util-gfm@3.0.0, npm/mdast-util-gfm-footnote@2.0.0, npm/mdast-util-gfm-strikethrough@2.0.0, npm/mdast-util-gfm-table@2.0.0, npm/mdast-util-gfm-task-list-item@2.0.0, npm/micromark-extension-gfm@3.0.0, npm/micromark-extension-gfm-tagfilter@2.0.0, npm/remark-gfm@4.0.0, npm/load-tsconfig@0.2.5, npm/tsup@7.2.0, npm/micromark-util-decode-numeric-character-reference@2.0.1, npm/clean-css@5.3.3, npm/clean-css-cli@5.6.3, npm/micromark-util-character@2.1.0, npm/mdast-util-phrasing@4.1.0, npm/trough@2.2.0, npm/eslint-plugin-storybook@0.8.0, npm/micromark-util-subtokenize@2.0.1, npm/micromark-core-commonmark@2.0.1, npm/react-refresh@0.14.2, npm/@types/mdast@4.0.4, npm/bundle-require@4.2.1, npm/unified@11.0.5, npm/micromark-extension-gfm-autolink-literal@2.1.0, npm/micromark-extension-gfm-footnote@2.1.0, npm/micromark-extension-gfm-strikethrough@2.1.0, npm/micromark-extension-gfm-table@2.1.0, npm/micromark-extension-gfm-task-list-item@2.1.0, npm/@lavamoat/preinstall-always-fail@2.1.0, npm/node-addon-api@7.1.1, npm/immutable@4.3.7, npm/@types/unist@3.0.3, npm/mdast-util-gfm-autolink-literal@2.0.1, npm/undici-types@6.19.8, npm/vfile@6.0.3, npm/rollup@3.29.5, npm/chokidar@4.0.1, npm/readdirp@4.0.2, npm/@vitejs/plugin-react@4.3.3, npm/markdown-table@3.0.4, npm/vite@5.4.10, npm/mdast-util-from-markdown@2.0.2, npm/sass@1.80.6, npm/@parcel/watcher-win32-ia32@2.5.0, npm/@parcel/watcher-darwin-x64@2.5.0, npm/@parcel/watcher-darwin-arm64@2.5.0, npm/@parcel/watcher-win32-x64@2.5.0, npm/@parcel/watcher-win32-arm64@2.5.0, npm/@parcel/watcher-linux-x64-glibc@2.5.0, npm/@parcel/watcher-linux-x64-musl@2.5.0, npm/@parcel/watcher-linux-arm64-glibc@2.5.0, npm/@parcel/watcher-linux-arm64-musl@2.5.0, npm/@parcel/watcher-linux-arm-glibc@2.5.0, npm/@parcel/watcher-linux-arm-musl@2.5.0, npm/@parcel/watcher-android-arm64@2.5.0, npm/@parcel/watcher-freebsd-x64@2.5.0, npm/@parcel/watcher@2.5.0, npm/@rollup/rollup-darwin-arm64@4.24.4, npm/@rollup/rollup-android-arm64@4.24.4, npm/@rollup/rollup-win32-arm64-msvc@4.24.4, npm/@rollup/rollup-freebsd-arm64@4.24.4, npm/@rollup/rollup-linux-arm64-gnu@4.24.4, npm/@rollup/rollup-linux-arm64-musl@4.24.4, npm/@rollup/rollup-android-arm-eabi@4.24.4, npm/@rollup/rollup-linux-arm-gnueabihf@4.24.4, npm/@rollup/rollup-linux-arm-musleabihf@4.24.4, npm/@rollup/rollup-win32-ia32-msvc@4.24.4, npm/@rollup/rollup-linux-riscv64-gnu@4.24.4, npm/@rollup/rollup-linux-powerpc64le-gnu@4.24.4, npm/@rollup/rollup-linux-s390x-gnu@4.24.4, npm/@rollup/rollup-darwin-x64@4.24.4, npm/@rollup/rollup-win32-x64-msvc@4.24.4, npm/@rollup/rollup-freebsd-x64@4.24.4, npm/@rollup/rollup-linux-x64-gnu@4.24.4, npm/@rollup/rollup-linux-x64-musl@4.24.4, npm/rollup@4.24.4, npm/mdast-util-to-markdown@2.1.2, npm/chromatic@11.16.5, npm/@types/node@22.9.0, npm/psl@1.10.0

View full report↗︎

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

@georgewrmarshall

Copy link
Copy Markdown
Contributor Author

@SocketSecurity ignore-all

  • Acceptable risk as lavamoat protects us from supply chain attacks and most of these dependencies will be consolidated in the next step
Screenshot 2024-11-12 at 12 48 42 PM

@georgewrmarshall georgewrmarshall marked this pull request as ready for review November 12, 2024 20:49
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner November 12, 2024 20:49
@mcmire

mcmire commented Nov 12, 2024

Copy link
Copy Markdown

Performed the same checks that @MajorLift did in #92 (review).

  • Confirmed that all design-tokens files appear in merged-packages/design-tokens with the correct structure using these commands:

    git remote add -f design-tokens https://github.com/MetaMask/design-tokens
    git remote update
    git diff HEAD:merged-packages/design-tokens remotes/design-tokens/main
    
  • Verified the commit history for design-tokens is intact and accurately reflects the original repository. I got the same output that @MajorLift posted earlier.

  • Ensured this PR meets all acceptance criteria.

@mcmire mcmire left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mcmire

mcmire commented Nov 12, 2024

Copy link
Copy Markdown

Once again just as a reminder make sure to press the dropdown next to the green button and select "Create a merge commit" :)

@georgewrmarshall georgewrmarshall merged commit 8f6a5de into main Nov 12, 2024
@georgewrmarshall georgewrmarshall deleted the migrate-design-tokens branch November 12, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate @metamask/design-tokens Package into Shared UI Component Library Monorepo