chore: update changelog#96
Merged
Merged
Conversation
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
georgewrmarshall
force-pushed
the
fix/95/update-changelog
branch
2 times, most recently
from
2ec3b1a to
7aabb90
Compare
georgewrmarshall
force-pushed
the
fix/95/update-changelog
branch
from
7aabb90 to
c2a38c9
Compare
brianacnguyen
previously approved these changes
Nov 13, 2024
| - Use the script to ensure that the tags have the correct package name prefixes. | ||
|
|
||
| 2. Create a fork of the metamask module template for testing, and push the ported tags to the test fork. | ||
| 2. Create a fork of the metamask design system for testing, and push the ported tags to the test fork. |
Contributor
Author
There was a problem hiding this comment.
fixes in migration docs
georgewrmarshall
force-pushed
the
fix/95/update-changelog
branch
from
ee501d8 to
98f1347
Compare
brianacnguyen
approved these changes
Nov 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the CHANGELOG tag links for the
design-tokenspackage to align with the MetaMask module template’s naming convention, following the migration of this package to themetamask-design-systemmonorepo. The updated tag format ensures that all tag diffs are consistent with the naming scheme and are correctly linked to the new@metamask/design-tokensnamespace for future releases.Related issues
Fixes: #95
Manual testing steps
merged-packages/design-tokenswithin themetamask-design-systemrepository.Screenshots/Recordings
After
after.mov
Pre-merge author checklist
Pre-merge reviewer checklist
validate-changelog.shscript to verify correct tag formatting).