Rename meshes#386
Draft
cjohnson-pi wants to merge 29 commits into
Draft
Conversation
github-actions
Bot
added
the
cla-required
28 tasks
28 tasks
|
Hello cjohnson-pi! 👋 Thank you for your contribution. Since this is your first time contributing to this repository, we ask that you sign our Contributor Licence Agreement (CLA). To agree to the CLA, please add your details (GitHub username, Real Name, Affiliation, and Date) to the CONTRIBUTORS.md file (create one, if required) in the development branch for this PR. After signing the CLA, you won't need to do this again for future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer:
Rename the meshes using an upgrade macro so that global meshes are: cubedsphere_l0, cubedsphere_l1, cubedsphere_l2 and regional meshes are planar_l0, planar_l1, planar_l2. (i.e. the same name as the mesh generator and partitioner) - and with the different levels (removing any reference to primary or dynamics meshes - they are all just meshes of different levels).
This will enable lfric2lfric to regrid from global to regional in the rose-stem test-suite. Currently both the global and regional meshes are named the same thing (dynamics), which causes problems for lfric2lfric - which requires the meshes to have different names.
In addition, as the coarse-level meshes are also not only used for multigrid, it is better to rename them to a more general purpose name.
MetOffice/lfric_apps#551
blocks MetOffice/lfric_apps#530
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_core - rename_meshes_core/run6
Suite Information
Task Information
❌ failed tasks - 87
⌛ waiting tasks - 2
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review