LFRic2LFRic - realistic cases, and tidying rose stem

[cjohnson-pi]

PR Summary

Sci/Tech Reviewer:
Code Reviewer:

Part 1:

Add realistic, large cases e.g. C896 to UKV

Part 2:

Enable the rose tasks to use multiple mesh files. This makes it a little easier to add new tasks, and avoids assumed dependencies on other tasks e.g. at the moment some lfric2lfric tasks are using meshes created by other tasks. This might cause failures if those meshes are not created in time or if the associated tasks are removed.

Single mesh (including multigrid) tasks (as current implementation):

{% do task_dict.update({
    "resolution": "C224_MG",

Multiple-mesh (double or more) tasks (new):

{% do task_dict.update({	
    "resolution": ["melbourne","C224"],

To enable this, the following files are changed.

rose-stem/templates/graph/populate_gen_weights_graph.cylc
• Lfric2lfric weight generation needs to use 2 meshes rather than 1.
• This is setup as:
build_mesh => run_mesh1 => run_mesh2 => generate_weights

rose-stem/templates/graph/populate_graph_sections.cylc
• Lfric2lfric regridding needs to use 2 meshes rather than 1.
• This is set up as:

build_mesh => run_mesh1
build_mesh => run_mesh2
build_application => run_application

(This assumes that building the application takes longer than building and creating the meshes, as also assumed currently).

rose-stem/templates/runtime/generate_runtime_application.cylc
• Remove adding the mesh .conf file to the lfric2lfric task options (its only needed to generate the meshes)

Part 3:

Reorganise the rose-stem groups.

Task name	Regrid method	cpu	source	destination	iodef	Keep	Rename?	Group
ral_seuk-C32_lam_MG_1cpu	map	1	seuk dynamics	seuk multigrid_l1	iodef_ral	N
ral_seuk-C32_lam_MG_4cpu	map	4	seuk dynamics	seuk multigrid_l1	iodef_ral	Y	map_seuk_dyn_to_seuk_l1_ral	developer
oasis_ral_seuk-C32_lam_MG_1cpu	oasis	1	seuk_dynamics	seuk multigrid_l1	iodef_ral	N
oasis_ral_seuk-C32_lam_MG_4cpu	oasis	4	seuk_dynamics	seuk multigrid_l1	iodef_ral	Y	oasis_seuk_dyn_to_seuk_l1_ral	developer
ral3-seuk	map	1	seuk dynamics	seuk multigrid_l1	iodef_ral3	Y	map_seuk_dyn_to_seuk_l1_ral3_1cpu	extra
ral3-uk	map	1	seuk dynamics	seuk multigrid_l1	iodef_ral3	N
ral3-ukv	map	1	seuk dynamics	seuk multigrid_l1	iodef_ral3	N
clim_gal9-C24_C12_1cpu	map	1	C24	C12	iodef	N
clim_gal9-C24_C12_6cpu	map	6	C24	C12	iodef	Y	map_C24_to_C12	developer
oasis_clim_gal9-C24_C12_1cpu	oasis	1	C24	C12	iodef	N
oasis_clim_gal9-C24_C12_6cpu	oasis	6	C24	C12	iodef	Y	oasis_C24_to_C12	extra
oasis_clim_gal9_C12-ral_seuk_C16_lam_1cpu	oasis	1	C12	seuk dynamics	iodef	Y	oasis_C12_to_seuk_1cpu	developer
oasis_clim_gal9_C12-ral_seuk_C16_lam_4cpu	oasis	4	C12	seuk dynamics	iodef	Y	oasis_C12_to_seuk	extra
oasis_clim_gal9_C12-ral_seuk_C16_lam-lbc_1cpu	oasis	1	C12	seuk dynamics-lbc	iodef	N
oasis_clim_gal9_C12-ral_seuk_C16_lam-lbc_4cpu	oasis	4	C12	seuk dynamics-lbc	iodef	Y	oasis_C12_to_seuk_lbc	developer

Plus new tasks oasis_C224_to_Melbourne, oasis_C896_to_Melbourne and oasis_C896_to_ukv added to the weekly group.

The tasks and configs have been reorganised with the aim that the user supplies

• the mesh file names
• the source configuration (mesh names, ancils, vertical levels)
• the destination configuration (mesh names, ancils, vertical levels)
  Have to be careful that the mesh names of the 2 meshes can not be the same - but most meshes are named dynamics, so some are renamed.

Likely some further organisation will be required. But this is a start!

is blocked-by MetOffice/lfric_core#386

Code Quality Checklist

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• All automated checks in the CI pipeline have completed successfully

Testing

• I have tested this change locally, using the LFRic Apps rose-stem suite
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable