Skip to content

Move from alpharaw#275

Open
mschwoer wants to merge 16 commits intomainfrom
move_from_alpharaw
Open

Move from alpharaw#275
mschwoer wants to merge 16 commits intomainfrom
move_from_alpharaw

Conversation

@mschwoer
Copy link
Copy Markdown
Contributor

@mschwoer mschwoer commented Mar 17, 2026

Move code over from alpharaw (cf. MannLabs/alpharaw#116)

Copy link
Copy Markdown
Collaborator

@GeorgWa GeorgWa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Could we get rid of the NormalDIAGrouper?
It's not used anywhere to my knowledge.

@jalew188
Copy link
Copy Markdown
Collaborator

jalew188 commented Apr 2, 2026

Looks good! Could we get rid of the NormalDIAGrouper? It's not used anywhere to my knowledge.

Greet, now we have alphadia to do this

@mschwoer
Copy link
Copy Markdown
Contributor Author

@GeorgWa @jalew188 unfortunately, not:

Yes, NormalDIAGrouper is actively used. Here's the full call chain:

  1. NormalDIAGrouper — defined in match/normal_dia.py:11, instantiated in match/psm_match.py:529
  2. PepSpecMatch_DIA._match_ms2_one_raw_numba (match/psm_match.py:497) — the method that creates the NormalDIAGrouper
  3. PepSpecMatch._match_ms2_one_raw_numba is called at match/psm_match.py:429 (polymorphic call via self, dispatches to the DIA override)
  4. This is called from match_psms() (pipeline_api.py:152), which creates PepSpecMatch_DIA at line 212 when the PSM type is not DDA
  5. match_psms() is called from transfer_learn() (pipeline_api.py:360)
  6. transfer_learn() is called from:
    - cli.py:133 and cli.py:170 (CLI entry points)
    - webui/server.py:57 (web UI)

  So NormalDIAGrouper is actively in use — it's part of the DIA PSM matching pipeline, reachable from both the CLI and the web UI via transfer_learn -> match_psms -> PepSpecMatch_DIA._match_ms2_one_raw_numba.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants