app: Briefing tab — intent, instruments, findings, and visual recap as the review's front page#28
Merged
Merged
Conversation
10dae8b to
e7d7dd0
Compare
… recap Add a Briefing tab as the review workspace's first tab and default landing while a review is fresh (a distilled intent or findings for the current head). It renders, top to bottom: the agent's read (IntentHero over AgentCallout), a curated instrument row of deterministic signals, the severity-ranked findings with jump-to-diff, and the visual recap (Excalidraw scenes + MDX). An empty review offers to run the advisory pre-review; a stale recap shows an amber regenerate nudge. - initialReviewTab pure fn + recap staleness / severity-sort / scene-guard helpers, each unit-tested. - Store: recaps map + fetchRecap (best-effort), pendingDiffJump + requestDiffJump bridging a Briefing "Jump" into DiffView's existing reveal machinery. - Excalidraw lazy-loaded (React.lazy) in its own chunk; fonts self-hosted under public/excalidraw so the viewer renders offline (no esm.sh CDN fetch). - App refetches the recap on agent-completed (pre-review regenerates it without moving the head). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
d6acce6 to
4b79f0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PR 4/7 of the overnight UX program (Track A centerpiece —
cockpit-docs/OVERNIGHT_UX_PLAN.md). Stacked on #27.IntentHero(AgentCallout writ large, sha provenance),InstrumentRow(CI / size / risk / tests / files / severity chips),BriefingFindings(severity-ranked, full rationale, Jump),RecapView(scenes-before-prose + stale regenerate nudge + safe Markdown).@excalidraw/excalidrawin an isolated ~1.1 MB lazy chunk (entry bundle unchanged, zero CDN refs), read-only, error-boundary + parse-fallback, fonts self-hosted underpublic/excalidraw/(480 KB, CJK excluded → system fallback).pendingDiffJumpstore contract (nonce-keyed, PR-scoped, consumed once) feeding DiffView's existing reveal+flash — PR 5 and PR 7 reuse it.Verified
tscclean ·vitest313 (20 new) ·vite buildwith chunk isolation verified (no esm.sh/static Excalidraw refs in entry). Frontend-only; Diff-tab bands untouched (they move in PR 5). Reviewer pass: SHIP, no blockers.🤖 Generated with Claude Code