app: persistent agent strip in Diff tab + board-card severity escalation#29
Merged
Merged
Conversation
LifeLex
force-pushed
the
alejandro/briefing-tab
branch
from
d6acce6 to
4b79f0d
Compare
…ands to Briefing Mockup A2. Add an always-visible, never-collapsible AgentStrip directly under the Diff-tab header: the one-line "agent's read" (markdown stripped, never rendered), live severity chips (n CRIT/WARN/INFO, non-zero only), and a link to the full Briefing. Renders nothing when the review has neither intent nor findings. Props-driven with no store reads so PR 7's board preview rail can reuse it. Remove the IntentPanel and EvidenceStrip bands from DiffView — their content now lives on the Briefing tab (hero + instrument row). Both components became fully unused (grep confirms no other importers; EvidenceStrip's classifyAgentRan / isVerificationCommand had no external users), so the component and test files are deleted. Deleting tests of deleted components is dead-code hygiene, not test-weakening. FindingsPanel stays and remains reachable on its own; its auto-expand-on-critical is unchanged (findingsAutoExpand). Now-dead DiffView state/effects (intent disclosure, evidence fetch, raw ci-checks, findings-panel scroll ref) are cleaned up; evidence fetching is dropped here since only the removed strip used it (the new strip's severity chips read review.review_findings). Add findingCounts() to finding-severity.ts — a pure, dismissal-agnostic per-severity counter shared by the strip (and the board cards). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…ation Mockup A3. Add advisory-finding severity chips to the card telemetry/risk row in both densities (n CRIT danger-toned, n WARN warning-toned; INFO omitted on cards), matching the existing chip anatomy (h-1.5 dot + mono tabular-nums label). Counts come from review.review_findings via the shared findingCounts helper — no new IPC; the board's existing refresh path repaints cards. Escalate the reason line to danger tone (red dot + red uppercase text) — "Needs your review · Agent flagged N critical" — when a review has ≥1 Critical finding. Slotted directly below CI-failing and above the softer size / sensitive-path notes (documented in card-signal.ts): a broken build stays the headline (chip only for criticals then), stale still preempts everything, and warning-only findings never escalate (chips only). Adds a "danger" SignalTone. Existing card-signal / ReviewCard expectations are unchanged except where the new spec applies; no assertions were loosened. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
LifeLex
force-pushed
the
alejandro/diff-strip-card-chips
branch
from
1068e2f to
f08887c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PR 5/7 of the overnight UX program (mockups A2 + A3 —
cockpit-docs/OVERNIGHT_UX_PLAN.md). Stacked on #28.Verified
tscclean ·vitest319 (29 files; new AgentStrip/card-signal/finding-severity suites, ReviewCard tests extended additively) ·vite buildok · grep-verified zero dangling references to deleted components. Reviewer pass: SHIP; both NITs addressed (stale comments reworded; brand-colored BRIEFING link kept — it matches the approved mockup's agent-voice treatment).🤖 Generated with Claude Code