Skip to content

Fix incorrect assumptions in drawingbuffer-storage-test. #3770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kenrussell merged 1 commit into from
Apr 14, 2026
+13 −5
Merged

Fix incorrect assumptions in drawingbuffer-storage-test. #3770

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions sdk/tests/js/tests/drawingbuffer-storage-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ let height;
let format;
let hasDrawingBufferStorage;
let maxRenderbufferSize;
let currentWidth;
let currentHeight;

function runTest(contextVersion) {
description();
Expand Down Expand Up @@ -185,19 +187,25 @@ function runTest(contextVersion) {
return;
}

// https://registry.khronos.org/webgl/specs/latest/1.0/#2.2 does
// not guarantee that a drawing buffer of a given width and height
// can be allocated at exactly that size.

debug('Testing maximum size');
gl.drawingBufferStorage(gl.RGBA8, maxRenderbufferSize, maxRenderbufferSize);
shouldBe('gl.getError()', 'gl.NONE');
shouldBe('gl.drawingBufferWidth', 'maxRenderbufferSize');
shouldBe('gl.drawingBufferHeight', 'maxRenderbufferSize');
shouldBeTrue('gl.drawingBufferWidth <= maxRenderbufferSize');
shouldBeTrue('gl.drawingBufferHeight <= maxRenderbufferSize');
currentWidth = gl.drawingBufferWidth;
currentHeight = gl.drawingBufferHeight;

debug('Testing over-maximum width and ehgith');
debug('Testing over-maximum width and height');
gl.drawingBufferStorage(gl.RGBA8, maxRenderbufferSize+1, 16);
shouldBe('gl.getError()', 'gl.INVALID_VALUE');
gl.drawingBufferStorage(gl.RGBA8, 16, maxRenderbufferSize+1);
shouldBe('gl.getError()', 'gl.INVALID_VALUE');
shouldBe('gl.drawingBufferWidth', 'maxRenderbufferSize');
shouldBe('gl.drawingBufferHeight', 'maxRenderbufferSize');
shouldBe('gl.drawingBufferWidth', 'currentWidth');
shouldBe('gl.drawingBufferHeight', 'currentHeight');
}

function testDrawToCanvas() {
Expand Down
Loading