Fix incorrect assumptions in drawingbuffer-storage-test.#3770
Merged
kenrussell merged 1 commit intoKhronosGroup:mainfrom Apr 14, 2026
Merged
Fix incorrect assumptions in drawingbuffer-storage-test.#3770kenrussell merged 1 commit intoKhronosGroup:mainfrom
kenrussell merged 1 commit intoKhronosGroup:mainfrom
Conversation
It is not guaranteed that WebGL implementations can allocate a drawing buffer at any specific size. Avoid asserting that allocations up to the maximum renderbuffer size will succeed. Associated with https://crbug.com/332743717 .
lexaknyazev
approved these changes
Apr 10, 2026
|
That's probably triggered by something else, but this seems to have broken the WebGL extensions registry. For example, this used to return an actual spec and currently yields a directory structure: Last modified time seems to match the time at which this PR was merged. Same problem for all extensions under https://registry.khronos.org/webgl/extensions/ |
Member
Author
|
@tidoust I couldn't remember where I saw this report and just re-found your comment here :) The WebGL extension registry has been fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is not guaranteed that WebGL implementations can allocate a drawing buffer at any specific size. Avoid asserting that allocations up to the maximum renderbuffer size will succeed.
Associated with https://crbug.com/332743717 .