Skip to content

fix: ensure internal graal imports are ignored on windows #511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GauBen merged 3 commits into from
Sep 30, 2025
Merged

fix: ensure internal graal imports are ignored on windows #511

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9c0a8c3
fix: ensure internal graal imports are ignored on windows
GauBen Sep 30, 2025
fffdc40
another try
GauBen Sep 30, 2025
050e8bc
simpler windows detection
GauBen Sep 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...java/src/main/java/org/jahia/modules/javascript/modules/engine/jsengine/JSFileSystem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,15 @@ public class JSFileSystem implements FileSystem {
*
* For instance, it might receive
* <code>/META-INF/js/libs/react-i18next.js</code> (stringified output of the
* method) or <code>/usr/local/graalvm/languages/js</code> (internal import).
* method) or <code>/usr/local/graalvm/languages/js</code> (internal import) or
* even worse <code>d:\jdk17\languages\js</code> on Windows.
*
* This is safe-guarded by this <code>path.startsWith("/")</code> check until
* someone comes with a better solution.
*/
@Override
public Path parsePath(String path) {
if (path.startsWith("/")) {
if (path.startsWith("/") || path.contains(":\\")) {
Comment thread
GauBen marked this conversation as resolved.
Outdated
return Path.of(path);
}

Expand Down
Loading