Repository navigation
fix: ensure internal graal imports are ignored on windows - #511
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes a Windows-specific issue where internal GraalVM imports fail due to path format differences. The change adds detection for Windows absolute paths (containing ":") to prevent them from being processed as relative module imports.
- Added Windows path detection to identify absolute paths with drive letters
- Updated comment documentation to include Windows path example
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Contributor
|
Checked with |
x0h01
approved these changes
Sep 30, 2025
dgriffon
approved these changes
Sep 30, 2025
Contributor
|
Re-checked with:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing on Windows failed at a different yet unexpected step, see #500
Fix confirmed to be working by @x0h01 🎉
Checklist
Source code
Tests
Tip
Documentation to guide the reviews: How to do a code review