Skip to content

fix: ensure internal graal imports are ignored on windows - #511

Merged
GauBen merged 3 commits into
mainfrom
fix/windows
Sep 30, 2025
Merged

GauBen merged 3 commits into
mainfrom
fix/windows

Conversation

@GauBen

@GauBen GauBen commented Sep 30, 2025 •

Copy link
Copy Markdown
Member

Description

Testing on Windows failed at a different yet unexpected step, see #500

Fix confirmed to be working by @x0h01 🎉

Checklist

Source code

  • I've shared and documented any breaking change
  • I've reviewed and updated the jahia-depends

Tests

  • I've provided Unit and/or Integration Tests
  • I've updated the parent issue with required manual validations

Tip

Documentation to guide the reviews: How to do a code review

@GauBen
GauBen requested a review from a team as a code owner September 30, 2025 13:18
Copilot AI review requested due to automatic review settings September 30, 2025 13:18

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes a Windows-specific issue where internal GraalVM imports fail due to path format differences. The change adds detection for Windows absolute paths (containing ":") to prevent them from being processed as relative module imports.

  • Added Windows path detection to identify absolute paths with drive letters
  • Updated comment documentation to include Windows path example

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@x0h01

x0h01 commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Checked with javascript-modules-engine 0.10.0-SN (Git-last-commit-id: fffdc40)
no errors in log anymore

@GauBen GauBen self-assigned this Sep 30, 2025
@GauBen GauBen linked an issue Sep 30, 2025 that may be closed by this pull request
@GauBen
GauBen merged commit d6d6699 into main Sep 30, 2025
11 checks passed
@x0h01

x0h01 commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

Re-checked with:

  • new build of javascript-modules-engine 0.10.0-SN (Git-last-commit-id: 050e8bc)
  • luxe-jahia-demo 0.9.1
  • luxe-prepackaged-website 0.9.1 (Git-last-commit-id: 8e67f84e08a8484f3f66dbc3776869f8992e9a43)
    No errors.

@GauBen
GauBen deleted the fix/windows branch September 30, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Virtual FileSystem does not work on Windows

4 participants