Adapt to https://github.com/rocq-prover/rocq/pull/21947#2353
Merged
Alizter merged 1 commit intoHoTT:masterfrom Apr 23, 2026
Merged
Adapt to https://github.com/rocq-prover/rocq/pull/21947#2353Alizter merged 1 commit intoHoTT:masterfrom
Alizter merged 1 commit intoHoTT:masterfrom
Conversation
Alizter
approved these changes
Apr 23, 2026
There was a problem hiding this comment.
Pull request overview
Updates HoTT/Category theory files to remain compatible with the rocq-prover/rocq#21947 change around Asymmetric Patterns, while aiming to keep older toolchains working.
Changes:
- Augment
Set/Global Set Asymmetric Patternswith an additional (warning-guarded)... No Implicitsvariant. - Apply the same compatibility tweak broadly across the Categories development and global settings.
Reviewed changes
Copilot reviewed 127 out of 127 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| theories/Categories/Yoneda.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/UniversalProperties.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Structure/IdentityPrinciple.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Structure/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/SimplicialSets.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/SetCategory/Morphisms.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/SetCategory/Functors/SetProp.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/SetCategory/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/SemiSimplicialSets.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/PseudonaturalTransformation/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Pseudofunctor/RewriteLaws.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Pseudofunctor/Identity.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Pseudofunctor/FromFunctor.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Pseudofunctor/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Profunctor/Representable.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Profunctor/Identity.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Profunctor/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/ProductLaws.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/NaturalTransformation/Sum.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/NaturalTransformation/Prod.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/NaturalTransformation/Pointwise.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/NaturalTransformation/Paths.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/NaturalTransformation/Isomorphisms.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/NaturalTransformation/Identity.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/NaturalTransformation/Dual.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/NaturalTransformation/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/NaturalTransformation/Composition/Laws.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/NaturalTransformation/Composition/Functorial.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/NaturalTransformation/Composition/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/NatCategory.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Monoidal/MonoidalCategory.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Limits/Functors.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Limits/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/LaxComma/CoreParts.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/LaxComma/CoreLaws.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/LaxComma/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/KanExtensions/Functors.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/KanExtensions/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/InitialTerminalCategory/Pseudofunctors.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/InitialTerminalCategory/NaturalTransformations.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/InitialTerminalCategory/Functors.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/InitialTerminalCategory/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/IndiscreteCategory.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/HomotopyPreCategory.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/HomFunctor.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/GroupoidCategory/Morphisms.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/GroupoidCategory/Dual.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/GroupoidCategory/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Grothendieck/ToSet/Univalent.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Grothendieck/ToSet/Morphisms.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Grothendieck/ToSet/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Grothendieck/ToCat.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Grothendieck/PseudofunctorToCat.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/FundamentalPreGroupoidCategory.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/FunctorCategory/Morphisms.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/FunctorCategory/Functorial.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/FunctorCategory/Dual.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/FunctorCategory/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Functor/Sum.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Functor/Prod/Universal.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Functor/Prod/Functorial.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Functor/Prod/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Functor/Pointwise/Properties.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Functor/Pointwise/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Functor/Paths.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Functor/Identity.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Functor/Dual.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Functor/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Functor/Composition/Laws.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Functor/Composition/Functorial/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Functor/Composition/Functorial/Attributes.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Functor/Composition/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Functor/Attributes.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/ExponentialLaws/Law4/Law.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/ExponentialLaws/Law4/Functors.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/ExponentialLaws/Law3/Law.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/ExponentialLaws/Law3/Functors.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/ExponentialLaws/Law2/Law.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/ExponentialLaws/Law2/Functors.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/ExponentialLaws/Law1/Law.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/ExponentialLaws/Law1/Functors.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/ExponentialLaws/Law0.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/DualFunctor.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/DiscreteCategory.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/DependentProduct.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Comma/ProjectionFunctors.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Comma/Projection.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Comma/InducedFunctors.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Comma/Functorial.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Comma/Dual.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Comma/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/ChainCategory.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/CategoryOfSections/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/CategoryOfGroupoids.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Category/Univalent.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Category/Sum.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Category/Strict.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Category/Sigma/Univalent.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Category/Sigma/OnObjects.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Category/Sigma/OnMorphisms.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Category/Sigma/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Category/Prod.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Category/Pi.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Category/Paths.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Category/Objects.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Category/Morphisms.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Category/Dual.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Category/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Cat/Morphisms.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Cat/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Adjoint/UniversalMorphisms/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Adjoint/UnitCounitCoercions.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Adjoint/UnitCounit.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Adjoint/Pointwise.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Adjoint/Paths.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Adjoint/Identity.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Adjoint/HomCoercions.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Adjoint/Hom.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Adjoint/Functorial/Parts.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Adjoint/Functorial/Laws.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Adjoint/Functorial/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Adjoint/Dual.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Adjoint/Composition/LawsTactic.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Adjoint/Composition/IdentityLaws.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Adjoint/Composition/Core.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Categories/Adjoint/Composition/AssociativityLaw.v | Add warning-guarded Set Asymmetric Patterns No Implicits. |
| theories/Basics/Settings.v | Add warning-guarded Global Set Asymmetric Patterns No Implicits. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| (** This flag removes parameters from constructors in patterns that appear in a match statement. *) | ||
| Global Set Asymmetric Patterns. | ||
| Global Set Asymmetric Patterns. #[warning="-unknown-option"] Global Set Asymmetric Patterns No Implicits. |
| Set Implicit Arguments. | ||
| Generalizable All Variables. | ||
| Set Asymmetric Patterns. | ||
| Set Asymmetric Patterns. #[warning="-unknown-option"] Set Asymmetric Patterns No Implicits. |
| Set Implicit Arguments. | ||
| Generalizable All Variables. | ||
| Set Asymmetric Patterns. | ||
| Set Asymmetric Patterns. #[warning="-unknown-option"] Set Asymmetric Patterns No Implicits. |
5 tasks
Collaborator
|
@proux01 Thanks! |
Copilot AI
added a commit
that referenced
this pull request
Apr 24, 2026
Agent-Logs-Url: https://github.com/HoTT/Coq-HoTT/sessions/60bd284b-46b1-4a39-a188-6f84406801fe Co-authored-by: Alizter <8614547+Alizter@users.noreply.github.com>
This was referenced Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adapt to rocq-prover/rocq#21947
Should be backward compatible