Style: put asymmetric patterns commands on separate lines#2355
Closed
Style: put asymmetric patterns commands on separate lines#2355
Conversation
Split the combined `Set Asymmetric Patterns. #[warning="-unknown-option"] Set Asymmetric Patterns No Implicits.` line into separate lines across all 127 affected files:
Set Asymmetric Patterns.
#[warning="-unknown-option"]
Set Asymmetric Patterns No Implicits.
Also add a comment in `theories/Basics/Settings.v` noting that the
warning clause can be removed once our minimum Rocq version is 9.3.
Agent-Logs-Url: https://github.com/HoTT/Coq-HoTT/sessions/cf924724-049b-4592-8215-90cea9e6fef7
Co-authored-by: Alizter <8614547+Alizter@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Alizter
April 24, 2026 17:56
View session
Collaborator
|
@jdchristensen This replaces #2354 with a cleaner commit history. |
Collaborator
|
This looks fine, but now I'm wondering if any of those settings are needed in the Category theory library. Category.Core exports Basics.Overture, which should mean that everything in Basics.Settings is done... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set Asymmetric Patterns.and#[warning="-unknown-option"] Set Asymmetric Patterns No Implicits.onto separate lines in all 127 affected filestheories/Basics/Settings.vnoting the warning clause can be removed once minimum Rocq version is 9.3