feat(SDK-1161): add print-checks terminal screens and event vocabulary - #2584
Merged
Conversation
First slice of the print-checks feature (split out of #2572 for reviewability): the shared event constants and the two terminal screens of the upcoming print-checks flow, PrintChecksFailure and PrintChecksSummary. Both are standalone, presentational components that will be wired into a state-machine orchestrator in a follow-up PR stacked on this one. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Aug 18, 2026
serikjensen
approved these changes
Aug 19, 2026
Comment on lines
+16
to
+22
| <Suspense fallback={<div>Loading translations...</div>}> | ||
| <I18nLoader> | ||
| <MockBaseProvider> | ||
| <Story /> | ||
| </MockBaseProvider> | ||
| </I18nLoader> | ||
| </Suspense> |
Member
There was a problem hiding this comment.
Nit: i think there should be a global configuration for this already so we don't have to reimplement for every story?
Comment on lines
+15
to
+22
| (Story: React.ComponentType) => ( | ||
| <Suspense fallback={<div>Loading translations...</div>}> | ||
| <I18nLoader> | ||
| <MockBaseProvider> | ||
| <Story /> | ||
| </MockBaseProvider> | ||
| </I18nLoader> | ||
| </Suspense> |
Member
There was a problem hiding this comment.
Same on this one, i feel like this is a global config somewhere?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
First of a 5-PR stack splitting up #2572 (print payroll checks) into reviewable pieces, per feedback on that PR's size. This slice:
printChecksEventstosrc/shared/constants.ts— the event vocabulary the rest of the stack builds on.PrintChecksFailureandPrintChecksSummary— the two terminal screens of the upcoming print-checks flow. Both are standalone, presentational components (no API calls) that readerrorMessage/documentUrlvia props and emitPRINT_CHECKS_RETRY/PRINT_CHECKS_CLOSE.Nothing in this PR is wired up to anything user-facing yet — that happens in later PRs in the stack.
knip/dead-code checks may flag these as currently unused; that's expected and resolves once PR 4 (state machine) wires them in.Stack
Testing
npm run test -- --run src/components/Payroll/PrintChecks— 6 tests passnpx tsc --noEmitandnpm run lint:checkclean🤖 Generated with Claude Code