Skip to content

feat(SDK-1161): add PrintChecks state machine and orchestrator - #2587

Merged
krisxcrash merged 6 commits into
mainfrom
kw/feat/print-checks-4-orchestrator
Aug 21, 2026
Merged

feat(SDK-1161): add PrintChecks state machine and orchestrator#2587
krisxcrash merged 6 commits into
mainfrom
kw/feat/print-checks-4-orchestrator

Conversation

@krisxcrash

Copy link
Copy Markdown
Contributor

Summary

Fourth PR in the print-checks stack (see #2584 for the full split rationale, splitting up #2572). This is where Banner/Form/Failure/Summary (PRs #2584-#2586) become the actual public Payroll.PrintChecks component.

  • printChecksStateMachine.tsx — a robot3 machine following the same pattern as ConfirmWireDetails/RecoveryCases: banner -> form -> summary/failure, unmounting each screen on transition rather than manually resetting form state.
  • PrintChecksComponents.tsx — the shared PrintChecksContextInterface + *Contextual wrapper components that connect each screen to the machine via FlowContext.
  • PrintChecks.tsx — the top-level orchestrator: BaseComponent + Root, mounts the banner unconditionally and the current screen inside a Modal.
  • No inert final() state, unlike the two reference machines (which define one but never transition to it) — per src/CLAUDE.md, hub-and-spoke components with no natural "end" shouldn't model completion as a final state.
  • Exports PrintChecks from the Payroll namespace and regenerates the SDK Dev App's component-props registry so companyId/payrollId are picked up as auto-provisioned entity IDs.

Base branch note: targets kw/feat/print-checks-3-form, stacked on PR #2586.

Stack

  1. feat(SDK-1161): add print-checks terminal screens and event vocabulary #2584 — terminal screens + events
  2. feat(SDK-1161): add PrintChecksBanner #2585 — Banner
  3. feat(SDK-1161): add PrintChecksForm #2586 — Form
  4. This PR — state machine / orchestrator
  5. PayrollOverview integration (stacked on this)

Testing

  • npm run test -- --run src/components/Payroll/PrintChecks — 24 tests pass (includes a new integration test exercising the full banner → form → summary/failure flow)
  • npx tsc --noEmit and npm run lint:check clean

🤖 Generated with Claude Code

krisxcrash and others added 4 commits August 18, 2026 15:11
First slice of the print-checks feature (split out of #2572 for
reviewability): the shared event constants and the two terminal
screens of the upcoming print-checks flow, PrintChecksFailure and
PrintChecksSummary. Both are standalone, presentational components
that will be wired into a state-machine orchestrator in a follow-up PR
stacked on this one.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Second slice of the print-checks feature stack (see #2584). A
standalone banner that fetches its own payroll data via
usePayrollsGet, shows an info alert when the payroll has employees
paid by check, and surfaces a "View and print checks" CTA once the
payroll is processed. Fires PRINT_CHECKS_START when clicked.

Stacked on kw/feat/print-checks-1-terminal-screens; targets that
branch, not main.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Third slice of the print-checks feature stack (see #2584). The core
piece: the check-stock form, the generate-and-poll cycle against
usePayrollsGeneratePrintableChecksMutation/useGeneratedDocumentsGet,
and the checks-download mechanism.

The download navigates directly to the generated document's signed
URL via a synthetic anchor click rather than fetching it into a blob:
the URL already has response-content-disposition=attachment baked
into its query string, so a direct browser-level request downloads it
via that response header. A client-side fetch() would be subject to
CORS, which the document host doesn't allow, and fails outright.

Defines a narrow PrintChecksFormFlowContext (just the isGenerating
flag its Footer needs from the shared machine context) rather than
depending on the orchestrator's full context type, which doesn't
land until the next PR in the stack — keeps this PR buildable and
testable on its own.

Stacked on kw/feat/print-checks-2-banner; targets that branch, not
main.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Fourth slice of the print-checks feature stack (see #2584). Wires
PrintChecksBanner/Form/Failure/Summary together into the public
Payroll.PrintChecks component via a robot3 state machine, following
the same pattern as ConfirmWireDetails/RecoveryCases: banner -> form
-> summary/failure, unmounting each screen on transition instead of
manually resetting form state.

No inert final() state, unlike the two reference machines that define
one but never transition to it -- per src/CLAUDE.md, hub-and-spoke
components (no natural "end", user can reopen the flow freely)
shouldn't model completion as a final state.

Exports PrintChecks from the Payroll namespace and regenerates the SDK
Dev App's component-props registry so it picks up companyId/payrollId
as auto-provisioned entity IDs.

Stacked on kw/feat/print-checks-3-form; targets that branch, not main.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Base automatically changed from kw/feat/print-checks-3-form to main August 20, 2026 22:06
@krisxcrash
krisxcrash enabled auto-merge August 21, 2026 15:54
@krisxcrash
krisxcrash added this pull request to the merge queue Aug 21, 2026
Merged via the queue into main with commit f759dd3 Aug 21, 2026
61 of 62 checks passed
@krisxcrash
krisxcrash deleted the kw/feat/print-checks-4-orchestrator branch August 21, 2026 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants