Skip to content

Regression harness cleanup: file(REMOVE_RECURSE) and drop legacy setservice key #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pchakraborty merged 2 commits into from
Aug 11, 2026
+1 −5
Merged

Regression harness cleanup: file(REMOVE_RECURSE) and drop legacy setservice key #415

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb9caa3
run_case.cmake: replace execute_process(rm -rf) with file(REMOVE_RECU…
pchakraborty Aug 11, 2026
6d3c397
adv-dyn: drop the now-redundant setservice (singular) key
pchakraborty Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions regression/adv-dyn/root.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,11 @@ mapl:
DYN:
dso: libFVdycoreCubed_GridComp
config_file: dyn.yaml
setservice: fvdycorecubed_setservices_
setservices: fvdycorecubed_setservices_

ADV:
dso: libFVdycoreCubed_GridComp
config_file: adv.yaml
setservice: advcore_setservices_
setservices: advcore_setservices_

DataMoist:
Expand Down
4 changes: 1 addition & 3 deletions regression/run_case.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,7 @@ function(run_case case_name regression_data_dir)
compare_results(${checkpoints_dir} ${expdir}/checkpoints/last)
endif()

execute_process(
COMMAND ${CMAKE_COMMAND} -E rm -rf ${expdir}
)
file(REMOVE_RECURSE ${expdir})
endfunction()

run_case(${TEST_CASE} ${REGRESSION_DATA_DIR})
Loading