Regression harness cleanup: file(REMOVE_RECURSE) and drop legacy setservice key - #415
Merged
Merged
Conversation
…RSE) Use CMake's native recursive-remove command instead of shelling out to rm -rf via execute_process.
#414 added setservices (plural) as the correct key alongside the old truncated setservice key for backward compatibility while the parser fix rolled out. Only setservices is needed now.
pchakraborty
added
0 diff trivial
mathomp4
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_case.cmake: replaceexecute_process(COMMAND ${CMAKE_COMMAND} -E rm -rf ${expdir})with the nativefile(REMOVE_RECURSE ${expdir}).regression/adv-dyn/root.yaml: drop the now-redundantsetservice(singular, truncated) key. Fix regression test setservices key and re-enable expdir cleanup #414 addedsetservices(plural, correct) alongside it for backward compatibility while the MAPL parser fix rolled out; onlysetservicesis needed now.Test plan