Skip to content

Make full screen persist after closing FT in full screen window and player. #8880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caetano-dev wants to merge 3 commits into
base: development
Choose a base branch
from
+47 −4
Open

Make full screen persist after closing FT in full screen window and player. #8880

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2014403
Make FT reopen in fullscreen after being closed with FS window and pl…
caetano-dev Mar 26, 2026
07bf860
Fix FT opening in FS just because the video was FS
caetano-dev Mar 27, 2026
3d5ea25
Fix fullscreen state detection race condition
caetano-dev Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/main/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -871,6 +871,7 @@ function runApp() {
}

const htmlFullscreenWindowIds = new Set()
const windowFullscreenBeforeHtmlFullscreen = new Map()

async function createWindow(
{
Expand Down Expand Up @@ -1159,16 +1160,20 @@ function runApp() {
}

newWindow.on('enter-html-full-screen', () => {
windowFullscreenBeforeHtmlFullscreen.set(newWindow.id, newWindow.isFullScreen())
htmlFullscreenWindowIds.add(newWindow.id)
})

newWindow.on('leave-html-full-screen', () => {
htmlFullscreenWindowIds.delete(newWindow.id)
windowFullscreenBeforeHtmlFullscreen.delete(newWindow.id)
})

newWindow.once('close', async () => {
// returns true if the element existed in the set
const htmlFullscreen = htmlFullscreenWindowIds.delete(newWindow.id)
const wasFullscreenBeforeHtml = windowFullscreenBeforeHtmlFullscreen.get(newWindow.id) ?? false
windowFullscreenBeforeHtmlFullscreen.delete(newWindow.id)

if (BrowserWindow.getAllWindows().length !== 1) {
return
Expand All @@ -1179,7 +1184,8 @@ function runApp() {
maximized: newWindow.isMaximized(),

// Don't save the full screen state if it was triggered by an HTML API e.g. the video player
fullScreen: newWindow.isFullScreen() && !htmlFullscreen
// But do save it if the window was already in fullscreen before entering HTML fullscreen
fullScreen: newWindow.isFullScreen() && (!htmlFullscreen || wasFullscreenBeforeHtml)
}

await baseHandlers.settings._updateBounds(value)
Expand Down
Loading