Skip to content

Make full screen persist after closing FT in full screen window and player.#8880

Open
caetano-dev wants to merge 3 commits intoFreeTubeApp:developmentfrom
caetano-dev:reopenFullscreen
Open

Make full screen persist after closing FT in full screen window and player.#8880
caetano-dev wants to merge 3 commits intoFreeTubeApp:developmentfrom
caetano-dev:reopenFullscreen

Conversation

@caetano-dev
Copy link
Copy Markdown
Contributor

@caetano-dev caetano-dev commented Mar 26, 2026

Pull Request Type

  • Bugfix

Related issue

Closes #8618

Description

Fixes a bug that caused FT to do not reopen in full screen after being closed with a full screen window and player.

Testing

  1. Open FT in full screen
  2. Open video player in full screen
  3. Close FT
  4. Reopen and see it is in full screen (before, it would not be in full screen)

Desktop

  • OS: MacOS
  • OS Version: Tahoe 26.4
  • FreeTube version: v0.23.15 Beta

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Mar 26, 2026
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 26, 2026 22:45
@absidue
Copy link
Copy Markdown
Member

absidue commented Mar 26, 2026

The tests from #5138 will need to be done too, to ensure that this doesn't reintroduce the issues that the original pull request fixed.

absidue
absidue requested changes Mar 26, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reintroduces the original bug of the FreeTube launching in fullscreen when the player was fullscreened without the window being fullscreened before and that bug is worse than the one this pull request is attempting to fix.

Steps:

  1. Launch FreeTube
  2. Make sure the window is windowed/not full screen
  3. Open a video
  4. Full screen the video player
  5. CTRL/COMMAND+W
  6. Re-open FreeTube
  7. It should be windowed

Number 7 is broken with this pull request.

@absidue absidue added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Mar 26, 2026
auto-merge was automatically disabled March 27, 2026 11:51

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 27, 2026 11:52
@caetano-dev
Copy link
Copy Markdown
Contributor Author

caetano-dev commented Mar 27, 2026

Good catch. I tested the following scenarios:

windowed -> open video without full screen player -> reopen as windowed
windowed -> open video in full screen player -> reopen as windowed
full screen -> open video without full screen player -> reopen as full screen
full screen -> open video with full screen player -> reopen as full screen

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Copy Markdown
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Mar 27, 2026 •
edited
Loading

Before i try did you test against these cases?
#5138 (review)

@caetano-dev
Copy link
Copy Markdown
Contributor Author

caetano-dev commented Mar 27, 2026

Yes, I tested these cases and they work.
Tested on MacOS.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Copy Markdown
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Mar 30, 2026

Created a build and tested this but it unfortunatly doesnt pass this case

Full screen doesn't persist if player is full-screened

  1. Open a video
  2. Full screen the player, either through the button or the F hotkey
  3. Close the app e.g. Ctrl+Q or Alt+F4
  4. Open the app again and make sure it launches with normal window dimensions

auto-merge was automatically disabled March 30, 2026 17:57

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) March 30, 2026 17:57
@caetano-dev
Copy link
Copy Markdown
Contributor Author

caetano-dev commented Mar 30, 2026

The previous version was working on MacOS, but broken on Linux and Windows, as you pointed out.

I applied a fix and now these 4 scenarios seem to pass. I tested it on MacOS and Linux, but I don't have access to a Windows machine.

windowed -> open video without full screen player -> reopen as windowed
windowed -> open video in full screen player -> reopen as windowed

full screen -> open video without full screen player -> reopen as full screen
full screen -> open video with full screen player -> reopen as full screen

@caetano-dev caetano-dev requested a review from absidue March 30, 2026 21:38
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Copy Markdown
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Mar 31, 2026

Retested again on Windows and its almost good. My window is always maximized but when exiting fullscreen it will go into windowed mode.

In it also returns into windowed mode instead of maximized

Full screen doesn't persist if player is full-screened

  1. Open a video
  2. Full screen the player, either through the button or the F hotkey
  3. Close the app e.g. Ctrl+Q or Alt+F4
  4. Open the app again and make sure it launches with normal window dimensions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@absidue absidue Awaiting requested review from absidue

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

PR: changes requested

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Full screen does not persist when both player and window is in full screen

3 participants

@caetano-dev @absidue @efb4f5ff-1298-471a-8973-3d47447115dc