Repository navigation
refactor(telemetry): remove package_name and package_version fields - #188
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Benchmark
Details
| Benchmark suite | Current: 2735268 | Previous: 06b3853 | Ratio |
|---|---|---|---|
commit_parsing/100 |
17296 ns/iter (± 111) |
14696 ns/iter (± 144) |
1.18 |
commit_parsing/1000 |
174363 ns/iter (± 4230) |
148697 ns/iter (± 2399) |
1.17 |
commit_parsing/10000 |
1819392 ns/iter (± 20795) |
1535265 ns/iter (± 20920) |
1.19 |
changelog/build_50 |
8664 ns/iter (± 58) |
7293 ns/iter (± 52) |
1.19 |
changelog/build_500 |
75655 ns/iter (± 511) |
60342 ns/iter (± 298) |
1.25 |
version_files/toml_read |
8479 ns/iter (± 53) |
5577 ns/iter (± 147) |
1.52 |
version_files/toml_write |
148674 ns/iter (± 14323) |
86481 ns/iter (± 19168) |
1.72 |
version_files/json_read |
5289 ns/iter (± 36) |
2696 ns/iter (± 48) |
1.96 |
version_files/json_write |
146409 ns/iter (± 13518) |
82910 ns/iter (± 8733) |
1.77 |
version_files/xml_read |
5099 ns/iter (± 24) |
2396 ns/iter (± 8) |
2.13 |
version_files/xml_write |
145090 ns/iter (± 13755) |
90603 ns/iter (± 15034) |
1.60 |
version_files/gradle_read |
4989 ns/iter (± 21) |
2310 ns/iter (± 18) |
2.16 |
version_files/gradle_write |
186169 ns/iter (± 22900) |
79828 ns/iter (± 5635) |
2.33 |
config_loading/single |
10337 ns/iter (± 85) |
5174 ns/iter (± 262) |
2.00 |
config_loading/mono_10 |
15566 ns/iter (± 198) |
9835 ns/iter (± 178) |
1.58 |
config_loading/mono_50 |
39192 ns/iter (± 344) |
32633 ns/iter (± 309) |
1.20 |
This comment was automatically generated by workflow using github-action-benchmark.
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 2735268 | Previous: 06b3853 | Ratio |
|---|---|---|---|
changelog/build_500 |
75655 ns/iter (± 511) |
60342 ns/iter (± 298) |
1.25 |
version_files/toml_read |
8479 ns/iter (± 53) |
5577 ns/iter (± 147) |
1.52 |
version_files/toml_write |
148674 ns/iter (± 14323) |
86481 ns/iter (± 19168) |
1.72 |
version_files/json_read |
5289 ns/iter (± 36) |
2696 ns/iter (± 48) |
1.96 |
version_files/json_write |
146409 ns/iter (± 13518) |
82910 ns/iter (± 8733) |
1.77 |
version_files/xml_read |
5099 ns/iter (± 24) |
2396 ns/iter (± 8) |
2.13 |
version_files/xml_write |
145090 ns/iter (± 13755) |
90603 ns/iter (± 15034) |
1.60 |
version_files/gradle_read |
4989 ns/iter (± 21) |
2310 ns/iter (± 18) |
2.16 |
version_files/gradle_write |
186169 ns/iter (± 22900) |
79828 ns/iter (± 5635) |
2.33 |
config_loading/single |
10337 ns/iter (± 85) |
5174 ns/iter (± 262) |
2.00 |
config_loading/mono_10 |
15566 ns/iter (± 198) |
9835 ns/iter (± 178) |
1.58 |
config_loading/mono_50 |
39192 ns/iter (± 344) |
32633 ns/iter (± 309) |
1.20 |
This comment was automatically generated by workflow using github-action-benchmark.
BryanFRD
added a commit
that referenced
this pull request
Apr 22, 2026
…188) * fix(docker): recreate wasm stub before final build * fix(docker): recreate bench stub before final build * refactor(telemetry): remove package_name and package_version fields
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package_nameandpackage_versionfrom telemetry event payloadsevent_type,repo_hash(SHA-256), andcommits_count