Skip to content

refactor(telemetry): remove package_name and package_version fields - #188

Merged
BryanFRD merged 3 commits into
mainfrom
refactor/strip-telemetry-fields
Mar 31, 2026
Merged

BryanFRD merged 3 commits into
mainfrom
refactor/strip-telemetry-fields

Conversation

@BryanFRD

@BryanFRD BryanFRD commented Mar 31, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Remove package_name and package_version from telemetry event payloads
  • These fields were the most identifying data points sent — removing them makes telemetry truly anonymous
  • Telemetry now only sends: event_type, repo_hash (SHA-256), and commits_count

@codecov

codecov Bot commented Mar 31, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/monorepo.rs 0.00% 3 Missing ⚠️
src/config.rs 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Details
Benchmark suite Current: 2735268 Previous: 06b3853 Ratio
commit_parsing/100 17296 ns/iter (± 111) 14696 ns/iter (± 144) 1.18
commit_parsing/1000 174363 ns/iter (± 4230) 148697 ns/iter (± 2399) 1.17
commit_parsing/10000 1819392 ns/iter (± 20795) 1535265 ns/iter (± 20920) 1.19
changelog/build_50 8664 ns/iter (± 58) 7293 ns/iter (± 52) 1.19
changelog/build_500 75655 ns/iter (± 511) 60342 ns/iter (± 298) 1.25
version_files/toml_read 8479 ns/iter (± 53) 5577 ns/iter (± 147) 1.52
version_files/toml_write 148674 ns/iter (± 14323) 86481 ns/iter (± 19168) 1.72
version_files/json_read 5289 ns/iter (± 36) 2696 ns/iter (± 48) 1.96
version_files/json_write 146409 ns/iter (± 13518) 82910 ns/iter (± 8733) 1.77
version_files/xml_read 5099 ns/iter (± 24) 2396 ns/iter (± 8) 2.13
version_files/xml_write 145090 ns/iter (± 13755) 90603 ns/iter (± 15034) 1.60
version_files/gradle_read 4989 ns/iter (± 21) 2310 ns/iter (± 18) 2.16
version_files/gradle_write 186169 ns/iter (± 22900) 79828 ns/iter (± 5635) 2.33
config_loading/single 10337 ns/iter (± 85) 5174 ns/iter (± 262) 2.00
config_loading/mono_10 15566 ns/iter (± 198) 9835 ns/iter (± 178) 1.58
config_loading/mono_50 39192 ns/iter (± 344) 32633 ns/iter (± 309) 1.20

This comment was automatically generated by workflow using github-action-benchmark.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 2735268 Previous: 06b3853 Ratio
changelog/build_500 75655 ns/iter (± 511) 60342 ns/iter (± 298) 1.25
version_files/toml_read 8479 ns/iter (± 53) 5577 ns/iter (± 147) 1.52
version_files/toml_write 148674 ns/iter (± 14323) 86481 ns/iter (± 19168) 1.72
version_files/json_read 5289 ns/iter (± 36) 2696 ns/iter (± 48) 1.96
version_files/json_write 146409 ns/iter (± 13518) 82910 ns/iter (± 8733) 1.77
version_files/xml_read 5099 ns/iter (± 24) 2396 ns/iter (± 8) 2.13
version_files/xml_write 145090 ns/iter (± 13755) 90603 ns/iter (± 15034) 1.60
version_files/gradle_read 4989 ns/iter (± 21) 2310 ns/iter (± 18) 2.16
version_files/gradle_write 186169 ns/iter (± 22900) 79828 ns/iter (± 5635) 2.33
config_loading/single 10337 ns/iter (± 85) 5174 ns/iter (± 262) 2.00
config_loading/mono_10 15566 ns/iter (± 198) 9835 ns/iter (± 178) 1.58
config_loading/mono_50 39192 ns/iter (± 344) 32633 ns/iter (± 309) 1.20

This comment was automatically generated by workflow using github-action-benchmark.

@BryanFRD
BryanFRD merged commit 78fbf93 into main Mar 31, 2026
11 checks passed
@BryanFRD
BryanFRD deleted the refactor/strip-telemetry-fields branch March 31, 2026 14:13
BryanFRD added a commit that referenced this pull request Apr 22, 2026
…188)

* fix(docker): recreate wasm stub before final build

* fix(docker): recreate bench stub before final build

* refactor(telemetry): remove package_name and package_version fields
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant