Skip to content

Commit 3231e11

Browse files
authored
refactor(telemetry): remove package_name and package_version fields (#188)
* fix(docker): recreate wasm stub before final build * fix(docker): recreate bench stub before final build * refactor(telemetry): remove package_name and package_version fields
1 parent e6d532c commit 3231e11

3 files changed

Lines changed: 4 additions & 28 deletions

File tree

‎src/config.rs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -728,7 +728,7 @@ pub fn init(format: Option<ConfigFileFormat>) -> Result<()> {
728728
println!("Run: ferrflow check");
729729

730730
if config.workspace.anonymous_telemetry {
731-
telemetry::send_event(telemetry::EventType::Init, None, None, None, None);
731+
telemetry::send_event(telemetry::EventType::Init, None, None);
732732
}
733733

734734
Ok(())

‎src/monorepo.rs‎

Lines changed: 3 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ pub fn check(config_path: Option<&Path>, verbose: bool, json: bool) -> Result<()
5151
let result = run_release_logic(&root, &config, true, verbose, json);
5252

5353
if config.workspace.anonymous_telemetry {
54-
telemetry::send_event(telemetry::EventType::Check, None, None, None, None);
54+
telemetry::send_event(telemetry::EventType::Check, None, None);
5555
}
5656

5757
result
@@ -339,8 +339,6 @@ fn run_release_logic(
339339
if config.workspace.anonymous_telemetry {
340340
telemetry::send_event(
341341
telemetry::EventType::VersionBump,
342-
Some(&pkg.name),
343-
Some(&new_version),
344342
None,
345343
Some(commits.len() as i32),
346344
);
@@ -532,14 +530,8 @@ fn run_release_logic(
532530
}
533531

534532
if config.workspace.anonymous_telemetry {
535-
for (_, _, _, pkg_name, version, commit_count) in &tags_to_create {
536-
telemetry::send_event(
537-
telemetry::EventType::Release,
538-
Some(pkg_name),
539-
Some(version),
540-
None,
541-
Some(*commit_count),
542-
);
533+
for (_, _, _, _, _, commit_count) in &tags_to_create {
534+
telemetry::send_event(telemetry::EventType::Release, None, Some(*commit_count));
543535
}
544536
}
545537

‎src/telemetry.rs‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -26,10 +26,6 @@ pub enum EventType {
2626
struct EventPayload {
2727
event_type: EventType,
2828
#[serde(skip_serializing_if = "Option::is_none")]
29-
package_name: Option<String>,
30-
#[serde(skip_serializing_if = "Option::is_none")]
31-
package_version: Option<String>,
32-
#[serde(skip_serializing_if = "Option::is_none")]
3329
metadata: Option<serde_json::Value>,
3430
#[serde(skip_serializing_if = "Option::is_none")]
3531
repo_hash: Option<String>,
@@ -75,8 +71,6 @@ fn get_repo_hash() -> Option<String> {
7571

7672
pub fn send_event(
7773
event_type: EventType,
78-
package_name: Option<&str>,
79-
package_version: Option<&str>,
8074
metadata: Option<serde_json::Value>,
8175
commits_count: Option<i32>,
8276
) {
@@ -86,8 +80,6 @@ pub fn send_event(
8680

8781
let payload = EventPayload {
8882
event_type,
89-
package_name: package_name.map(String::from),
90-
package_version: package_version.map(String::from),
9183
metadata,
9284
repo_hash: get_repo_hash(),
9385
commits_count,
@@ -154,15 +146,11 @@ mod tests {
154146
fn payload_skips_none_fields() {
155147
let payload = EventPayload {
156148
event_type: EventType::Check,
157-
package_name: None,
158-
package_version: None,
159149
metadata: None,
160150
repo_hash: None,
161151
commits_count: None,
162152
};
163153
let json = serde_json::to_value(&payload).unwrap();
164-
assert!(!json.as_object().unwrap().contains_key("package_name"));
165-
assert!(!json.as_object().unwrap().contains_key("package_version"));
166154
assert!(!json.as_object().unwrap().contains_key("metadata"));
167155
assert!(!json.as_object().unwrap().contains_key("repo_hash"));
168156
assert!(!json.as_object().unwrap().contains_key("commits_count"));
@@ -172,16 +160,12 @@ mod tests {
172160
fn payload_includes_present_fields() {
173161
let payload = EventPayload {
174162
event_type: EventType::Release,
175-
package_name: Some("my-pkg".into()),
176-
package_version: Some("1.0.0".into()),
177163
metadata: None,
178164
repo_hash: Some("abc123".into()),
179165
commits_count: Some(42),
180166
};
181167
let json = serde_json::to_value(&payload).unwrap();
182168
assert_eq!(json["event_type"], "release");
183-
assert_eq!(json["package_name"], "my-pkg");
184-
assert_eq!(json["package_version"], "1.0.0");
185169
assert_eq!(json["repo_hash"], "abc123");
186170
assert_eq!(json["commits_count"], 42);
187171
}

0 commit comments

Comments
 (0)