refactor(profiling): more try_reserve fixes#2010
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoMay 19, 2026
Merged
Conversation
Contributor
Clippy Allow Annotation ReportComparing clippy allow annotations between branches:
Summary by Rule
Annotation Counts by File
Annotation Stats by Crate
About This ReportThis report tracks Clippy allow annotations for specific rules, showing how they've changed in this PR. Decreasing the number of these annotations generally improves code quality. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2010 +/- ##
==========================================
+ Coverage 72.67% 72.70% +0.02%
==========================================
Files 452 452
Lines 74889 74895 +6
==========================================
+ Hits 54427 54452 +25
+ Misses 20462 20443 -19
🚀 New features to boost your workflow:
|
🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage (details) 🔗 Commit SHA: b573dd3 | Docs | Datadog PR Page | Give us feedback! |
Contributor
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-unknown-linux-gnu
|
realFlowControl
approved these changes
May 18, 2026
morrisonlevi
force-pushed
the
PROF-14651-more-try-reserve
branch
from
fa94737 to
b573dd3
Compare
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
Tests failed on this commit 0ac6a82: What to do next?
|
Contributor
Author
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
PROF-14651-more-try-reserve
branch
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This migrates more
Veccode to usetry_reserve*.Makes two helpers,
try_clone_optional_tags, andtry_into_vec_files(which replacedinto_vec_filesand fixes some other panics in this helper too)..Motivation
Trying to reduce the places we panic without breaking APIs.
Additional Notes
This is based on #2002, so that should merge first.
There are still
Vec::with_capacitycalls in the code, but I think all of the remainder require either API breaks or parallel helpers, which I may investigate in future PRs.How to test the change?
Should test all the same!