Enable admission controller connectivity probe by default by adel121 · Pull Request #2795 · DataDog/helm-charts

adel121 · 2026-07-17T13:58:49Z

What this PR does / why we need it:

See title.

Which issue this PR fixes

Enabling this option allows users to get health signals about the connectivity state between the kubernetes api server and the cluster agent admission controller.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

All commits are signed and show as "Verified" on GitHub (see: signing commits)
Chart Version semver bump label has been added (use <chartName>/minor-version, <chartName>/patch-version, or <chartName>/no-version-bump)
For datadog or datadog-operator chart or value changes, update the test baselines (run: make update-test-baselines)
For datadog chart changes, received ✅ from a member of your team

GitHub CI takes care of the below, but are still required:

Documentation has been updated with helm-docs (run: .github/helm-docs.sh)
CHANGELOG.md has been updated
Variables are documented in the README.md

- bump version for datadog to 3.232.0 (minor-version) - update changelog for datadog with version 3.232.0 - update readme for datadog

github-actions · 2026-07-17T14:01:15Z

⚠️ GKE Autopilot / GDC Baseline Manifests Changed

This PR modifies GKE Autopilot or GDC baseline manifest snapshots. Before merging, confirm:

GKE Autopilot/GKE GDC baseline manifest diffs have been reviewed and confirmed to be supported in GKE Autopilot and the latest Datadog WorkloadAllowlist.

If changes introduce constraints not yet covered by the Datadog WorkloadAllowlist CR, gate them with {{- if not (or .Values.providers.gke.autopilot .Values.providers.gke.gdc) }} until the WorkloadAllowlist is updated.
See gke-constraints-review-guide.md for the full constraint reference.

- bump version for datadog to 3.232.0 (minor-version) - update changelog version for datadog to 3.232.0 - update readme for datadog

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 440ca36f52

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-07-27T12:29:00Z

      ## The probe periodically sends dry-run ConfigMap creation requests to verify the webhook is reachable from the API server.
      ## (Requires Cluster Agent 7.78.0+).
-      enabled: false
+      enabled: true


Keep the probe opt-in until a major release

For releases that do not explicitly pin clusterAgent.admissionController.probe.enabled, adopting this minor chart version silently enables a new periodic dry-run ConfigMap request every 60 seconds. The chart review guide classifies stable default changes as breaking and requires a deprecation notice, migration path, or major-version bump; keep this default false until one of those compatibility paths is provided.

AGENTS.md reference: AGENTS.md:L7-L7

Useful? React with 👍 / 👎.

adel121 · 2026-07-27T14:13:59Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-07-27T14:14:03Z

View all feedbacks in Devflow UI.

2026-07-27 14:14:03 UTC ℹ️ Start processing command /merge

2026-07-27 14:14:09 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 51m (p90).

2026-07-27 15:07:15 UTC ❌ MergeQueue: The build pipeline failed for this merge request

Build pipeline has failing jobs for 865bc7a:

e2e: [e2e_autopilot, 7-rc]

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

- update changelog version for datadog to 3.232.0

adel121 · 2026-07-28T14:13:26Z

/merge

gh-worker-devflow-routing-ef8351 · 2026-07-28T14:13:30Z

View all feedbacks in Devflow UI.

2026-07-28 14:13:30 UTC ℹ️ Start processing command /merge

2026-07-28 14:13:36 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 51m (p90).

2026-07-28 14:26:26 UTC ❌ MergeQueue: The build pipeline contains failing jobs for this merge request

Build pipeline has failing jobs for 82efbbb:

e2e: [e2e_autopilot_csi, 7-rc]

⚠️ Do NOT retry failed jobs directly (why?).

What to do next?

Investigate the failures and when ready, re-add your pull request to the queue!
If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
Any question, go check the FAQ.

Details

Since those jobs are not marked as being allowed to fail, the pipeline will most likely fail.
Therefore, and to allow other builds to be processed, this merge request has been rejected and the pipeline got canceled.

Enable admission controller connectivity probe by default

73a35d8

github-actions Bot added the chart/datadog This issue or pull request is related to the datadog chart label Jul 17, 2026

adel121 added the datadog/minor-version Minor version bump for datadog chart label Jul 17, 2026

dd-octo-sts Bot and others added 2 commits July 17, 2026 14:00

chore: update charts

734c529

- bump version for datadog to 3.232.0 (minor-version) - update changelog for datadog with version 3.232.0 - update readme for datadog

update baseline tests

e5d2110

adel121 and others added 2 commits July 27, 2026 14:03

Merge branch 'main' into adelhajhassan/set-dca-ac-probe-enabled

77a8f0e

chore: update charts

440ca36

- bump version for datadog to 3.232.0 (minor-version) - update changelog version for datadog to 3.232.0 - update readme for datadog

adel121 marked this pull request as ready for review July 27, 2026 12:26

adel121 requested review from a team as code owners July 27, 2026 12:26

adel121 requested review from gpalmz and removed request for a team July 27, 2026 12:26

chatgpt-codex-connector Bot reviewed Jul 27, 2026

View reviewed changes

tbavelier approved these changes Jul 27, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

update baseline tests

d02bf32

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: queued mergequeue-status: in_progress and removed mergequeue-status: queued labels Jul 27, 2026

gh-worker-devflow-routing-ef8351 Bot mentioned this pull request Jul 27, 2026

Mount run socket for host profiler/ ddot #2802

Merged

7 tasks

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: rejected and removed mergequeue-status: in_progress labels Jul 27, 2026

gpalmz approved these changes Jul 28, 2026

View reviewed changes

adel121 and others added 2 commits July 28, 2026 16:07

Merge branch 'main' into adelhajhassan/set-dca-ac-probe-enabled

9e78e36

chore: update charts

4eef15c

- update changelog version for datadog to 3.232.0

gh-worker-dd-devflow-36fce6 Bot added mergequeue-status: queued mergequeue-status: in_progress mergequeue-status: rejected and removed mergequeue-status: rejected mergequeue-status: queued mergequeue-status: in_progress labels Jul 28, 2026

Navigation Menu

Uh oh!

Enable admission controller connectivity probe by default - #2795

Enable admission controller connectivity probe by default#2795
adel121 wants to merge 8 commits into
mainfrom
adelhajhassan/set-dca-ac-probe-enabled

adel121 commented Jul 17, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 17, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jul 27, 2026

Uh oh!

This comment has been minimized.

adel121 commented Jul 27, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 27, 2026 •

edited

Loading

Uh oh!

adel121 commented Jul 28, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 28, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

adel121 commented Jul 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What this PR does / why we need it:

Which issue this PR fixes

Special notes for your reviewer:

Checklist

Uh oh!

github-actions Bot commented Jul 17, 2026

⚠️ GKE Autopilot / GDC Baseline Manifests Changed

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jul 27, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

adel121 commented Jul 27, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

adel121 commented Jul 28, 2026

Uh oh!

gh-worker-devflow-routing-ef8351 Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What to do next?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

adel121 commented Jul 17, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Jul 27, 2026 •

edited

Loading

gh-worker-devflow-routing-ef8351 Bot commented Jul 28, 2026 •

edited

Loading