Mount run socket for host profiler/ ddot - #2802
Conversation
github-actions
Bot
added
the
chart/datadog
- bump version for datadog to 3.231.5 (patch-version) - update changelog for datadog with version 3.231.5 - update readme for datadog
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76b959b13e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| - name: {{ include "datadog.agentRunVolumeName" . }} | ||
| mountPath: /opt/datadog-agent/run | ||
| readOnly: false |
There was a problem hiding this comment.
When targetSystem=windows and datadog.otelCollector.enabled=true with log collection left at its default disabled state, this helper expands to datadogrun, but daemonset-volumes-windows never defines a datadogrun volume; it only creates pointerdir when logs are enabled. The rendered DaemonSet therefore contains an otel-agent volumeMount with no matching volume and Kubernetes will reject the pod, so this mount needs a Windows-specific volume/path or should be limited to Linux.
Useful? React with 👍 / 👎.
|
- update readme for datadog
This comment has been minimized.
This comment has been minimized.
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
This merge request conflicts with another merge request ahead in the queue. The merge requests in front of this one are: |
- bump version for datadog to 3.231.8 (patch-version) - update changelog version for datadog to 3.231.8 - update readme for datadog
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
|
3 participants
What this PR does / why we need it:
This PR mounts the run socket for ddot/ hp.
Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
<chartName>/minor-version,<chartName>/patch-version, or<chartName>/no-version-bump)datadogordatadog-operatorchart or value changes, update the test baselines (run:make update-test-baselines)datadogchart changes, received ✅ from a member of your teamGitHub CI takes care of the below, but are still required:
.github/helm-docs.sh)CHANGELOG.mdhas been updatedREADME.md