Skip to content

Add more exception handlers to kubernetes config loading #5517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
avnig05 wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −1
Open

Add more exception handlers to kubernetes config loading #5517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/toil/test/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,6 +529,7 @@ def needs_kubernetes_installed(test_item: MT) -> MT:
def _is_kubernetes_installed_and_configured() -> bool:
try:
import kubernetes
import oauthlib.oauth2.rfc6749.errors # type: ignore[import-untyped]

try:
kubernetes.config.load_kube_config() # type: ignore[attr-defined]
Expand All @@ -537,7 +538,13 @@ def _is_kubernetes_installed_and_configured() -> bool:
kubernetes.config.load_incluster_config() # type: ignore[attr-defined]
except kubernetes.config.ConfigException: # type: ignore[attr-defined]
return False
except ImportError:
except oauthlib.oauth2.rfc6749.errors.CustomOAuth2Error:
logger.warning("Kubernetes credentials are not accepted by the cluster.")
return False
except Exception:
logger.exception("Unexpected error while checking for Kubernetes configuration.")
return False
except ImportError: # to catch any exception
return False
return True

Expand Down