Skip to content

Add more exception handlers to kubernetes config loading#5517

Open
avnig05 wants to merge 1 commit intomasterfrom
issues/5505-kube-pytest-fail
Open

Add more exception handlers to kubernetes config loading#5517
avnig05 wants to merge 1 commit intomasterfrom
issues/5505-kube-pytest-fail

Conversation

@avnig05
Copy link
Copy Markdown
Collaborator

@avnig05 avnig05 commented May 7, 2026

Hardens _is_kubernetes_installed_and_configured() in src/toil/test/init.py to gracefully handle invalid Kubernetes auth/config states. Adds explicit handling for oauthlib.oauth2.rfc6749.errors.CustomOAuth2Error when kube credentials are rejected by the cluster. Adds a broad safety catch for unexpected exceptions during config loading, logs context, and returns False so tests can skip Kubernetes-dependent paths cleanly.

Changelog Entry

To be copied to the draft changelog by merger:

  • PR submitter writes their recommendation for a changelog entry here

Reviewer Checklist

  • Make sure it is coming from issues/XXXX-fix-the-thing in the Toil repo, or from an external repo.
    • If it is coming from an external repo, make sure to pull it in for CI with:
      contrib/admin/test-pr otheruser theirbranchname issues/XXXX-fix-the-thing
      
    • If there is no associated issue, create one.
  • Read through the code changes. Make sure that it doesn't have:
    • Addition of trailing whitespace.
    • New variable or member names in camelCase that want to be in snake_case.
    • New functions without type hints.
    • New functions or classes without informative docstrings.
    • Changes to semantics not reflected in the relevant docstrings.
    • New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
    • New features without tests.
  • Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
  • Finish the review with an overall description of your opinion.

Merger Checklist

  • Make sure the PR passed tests, including the Gitlab tests, for the most recent commit in its branch.
  • Make sure the PR has been reviewed. If not, review it. If it has been reviewed and any requested changes seem to have been addressed, proceed.
  • Merge with the Github "Squash and merge" feature.
    • If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
  • Copy its recommended changelog entry to the Draft Changelog.
  • Append the issue number in parentheses to the changelog entry.

@avnig05 avnig05 requested a review from adamnovak May 7, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant