Port Create to Minecraft 26.2#10594
Closed
doscarchase wants to merge 1 commit into
Closed
Conversation
e61d646 to
c238e58
Compare
Collaborator
|
Regardless of the actual quality of this code, this PR is unmergeable. Nearly 40k lines of changes, in a single commit, is not possible to review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create.useMavenLocalso the default PR path resolves published coordinates only.pack.mcmetato resource major 88 and data format 107.1.Maintainer Note
mc26.2/devto be created frommc1.21.1/devbefore merge.403), so this PR is opened againstmc1.21.1/devand should be retargeted tomc26.2/devafter maintainers create it.Dependency PRs / Releases
Validation
./gradlew "-Pcreate.useMavenLocal" --offline clean build --stacktrace --no-daemon --console=plain->BUILD SUCCESSFUL in 49s./gradlew "-Pcreate.useMavenLocal" --offline runData --stacktrace --no-daemon --console=plain->BUILD SUCCESSFUL in 44srunDatacache summary:total files: 7499, old count: 7499, new count: 7499, removed stale: 0, written: 0./gradlew "-Pcreate.useMavenLocal" --offline runGameTestServer --stacktrace --no-daemon --console=plain->All 1 required tests passed :),BUILD SUCCESSFUL in 37s./gradlew -Pcreate.useMavenLocal --offline runServer --stacktrace --no-daemon --console=plain-> dedicated server reachedDone (0.320s)! For help, type "help"; harness stopped the validation JVM after startup../gradlew -Pcreate.useMavenLocal --offline runClient --stacktrace --no-daemon --console=plain-> client bootstrap reachedSound engine startedand created blocks/items/gui texture atlases; harness stopped the validation JVM after startup markers.Runtime Smoke
LocalPlayer,DISTXFORM, or unresolved Ponder/Catnip version-difference warnings.Deferred Optional Integrations