Port Create to Minecraft 26.2#10598
Closed
doscarchase wants to merge 3 commits into
Closed
Conversation
Collaborator
|
As you have been told previously, this is unmergeable. It is simply not possible to meaningfully review this much code in one go. If you are interested in genuinely helping with Create's development, I strongly encourage you to look at the countless issues already open. Many are still unconfirmed, and many confirmed issues are without PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create.useMavenLocalso the default PR path resolves published coordinates only.pack.mcmetato resource major 88 and data format 107.1.Maintainer Note
7ec030e99193b16f34eca960ee7ab298ab737c1e.mc26.2/devto be created frommc1.21.1/devbefore merge.403), so this PR is opened againstmc1.21.1/devand should be retargeted tomc26.2/devafter maintainers create it.mavenLocal()dependency probe resolves the official coordinates but reports missing Registrate, Ponder, Flywheel, and Vanillin 26.2 artifacts.Dependency PRs / Releases
Validation
./gradlew "-Pcreate.useMavenLocal" --offline clean build --stacktrace --no-daemon --console=plain->BUILD SUCCESSFUL in 48s./gradlew "-Pcreate.useMavenLocal" --offline runData --stacktrace --no-daemon --console=plain->BUILD SUCCESSFUL in 39srunDatacache summary:total files: 7499, old count: 7499, new count: 7499, removed stale: 0, written: 0./gradlew "-Pcreate.useMavenLocal" --offline runGameTestServer --stacktrace --no-daemon --console=plain->All 65 required tests passed :),BUILD SUCCESSFUL in 42s./gradlew -Pcreate.useMavenLocal --offline runServer --stacktrace --no-daemon --console=plain-> dedicated server reachedDone (0.341s)! For help, type "help"; harness stopped the validation JVM after startup../gradlew -Pcreate.useMavenLocal --offline runClient --stacktrace --no-daemon --console=plain-> client bootstrap reachedSound engine started, loaded Flywheel shaders, loaded 58 train hat configurations, and created the JEI GUI atlas; harness stopped the validation JVM after startup markers../gradlew --refresh-dependencies --no-daemon --console=plain dependencies --configuration runtimeClasspath-> dependency report completed, with required unpublished 26.2 dependency coordinates markedFAILED.Runtime Smoke
LocalPlayer,DISTXFORM, or unresolved Ponder/Catnip version-difference warnings.Deferred Optional Integrations