-
Notifications
You must be signed in to change notification settings - Fork 29
[ENG-9957] Users unable to delete/remove files from draft registrations when starting from scratch #972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
brianjgeiger
merged 17 commits into
CenterForOpenScience:feature/pbs-26-9
from
mkovalua:feature/ENG---9957
May 1, 2026
Merged
[ENG-9957] Users unable to delete/remove files from draft registrations when starting from scratch #972
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
fc7f300
open preview url on draft registry file click
mkovalua 68ceae9
add rendering page for draft registry files
mkovalua cdfdebb
update tests
mkovalua ea1d9a3
resolve CR
mkovalua 00a3372
resolve CR and update UI
mkovalua 29c9361
resolve CR comments
mkovalua 2573a81
update code
mkovalua abd255b
delete files from draft registrations
mkovalua c3611fe
resolve CR comments
mkovalua 960ce79
use some of CR approaches & keep some existing approaches to show the…
mkovalua 81d76dd
update tests and code
mkovalua c1a66e1
resolve CR comments
mkovalua f174f0a
update unittests
mkovalua bba5bfb
remove not used attribute
mkovalua 3ce619a
fix merge conflcts
mkovalua 835b490
Update allowedHosts in angular.json for security
mkovalua 39da56a
merge unittests fix
mkovalua File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
src/app/features/files/pages/file-preview/file-preview.component.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <osf-sub-header [isLoading]="isFileLoading()" title="{{ file()?.name }}" /> | ||
| <div class="flex gap-4 bg-white flex-column h-full flex-1 p-4 h-full"> | ||
| <div class="flex flex-column lg:flex-row gap-4 flex-1 h-full"> | ||
| <div class="w-full h-full lg:w-6"> | ||
| @if (safeLink) { | ||
| <iframe | ||
| [src]="safeLink" | ||
| (load)="isIframeLoading = false" | ||
| [hidden]="isIframeLoading" | ||
| title="Rendering of document" | ||
| marginheight="0" | ||
| frameborder="0" | ||
| allowfullscreen="" | ||
| class="full-image" | ||
| height="100%" | ||
| width="100%" | ||
| ></iframe> | ||
| } | ||
| @if (isIframeLoading) { | ||
| <osf-loading-spinner></osf-loading-spinner> | ||
| } | ||
| </div> | ||
|
|
||
| <div class="w-full flex flex-column gap-4 lg:w-6"> | ||
| <div class="metadata p-4 flex flex-column gap-2"> | ||
| <h2>{{ 'common.labels.metadata' | translate }}</h2> | ||
| <p>{{ 'files.detail.fileMetadata.previewNotAvailable' | translate }}</p> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> |
9 changes: 9 additions & 0 deletions
9
src/app/features/files/pages/file-preview/file-preview.component.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| .metadata { | ||
| border: 1px solid var(--grey-2); | ||
| border-radius: 0.75rem; | ||
| } | ||
|
|
||
| .full-image { | ||
| min-height: 100vh; | ||
| min-width: 100%; | ||
| } |
166 changes: 166 additions & 0 deletions
166
src/app/features/files/pages/file-preview/file-preview.component.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,166 @@ | ||
| import { Store } from '@ngxs/store'; | ||
|
|
||
| import { MockProvider } from 'ng-mocks'; | ||
|
|
||
| import { Mock } from 'vitest'; | ||
|
|
||
| import { ComponentFixture, TestBed } from '@angular/core/testing'; | ||
| import { ActivatedRoute, Router } from '@angular/router'; | ||
|
|
||
| import { FileKind } from '@osf/shared/enums/file-kind.enum'; | ||
| import { FileDetailsModel } from '@osf/shared/models/files/file.model'; | ||
| import { BaseNodeModel } from '@osf/shared/models/nodes/base-node.model'; | ||
| import { ViewOnlyLinkHelperService } from '@osf/shared/services/view-only-link-helper.service'; | ||
|
|
||
| import { provideOSFCore } from '@testing/osf.testing.provider'; | ||
| import { ActivatedRouteMockBuilder } from '@testing/providers/route-provider.mock'; | ||
| import { RouterMockBuilder, RouterMockType } from '@testing/providers/router-provider.mock'; | ||
| import { | ||
| BaseSetupOverrides, | ||
| mergeSignalOverrides, | ||
| provideMockStore, | ||
| SignalOverride, | ||
| } from '@testing/providers/store-provider.mock'; | ||
| import { ViewOnlyLinkHelperMock, ViewOnlyLinkHelperMockType } from '@testing/providers/view-only-link-helper.mock'; | ||
|
|
||
| import { FilesSelectors, GetFile } from '../../store'; | ||
|
|
||
| import { FilePreviewComponent } from './file-preview.component'; | ||
|
|
||
| interface SetupOverrides extends BaseSetupOverrides { | ||
| hasViewOnlyParam?: boolean; | ||
| viewOnlyParam?: string | null; | ||
| renderLink?: string; | ||
| } | ||
|
|
||
| describe('FilePreviewComponent', () => { | ||
| let component: FilePreviewComponent; | ||
| let fixture: ComponentFixture<FilePreviewComponent>; | ||
| let store: Store; | ||
| let mockRouter: RouterMockType; | ||
| let viewOnlyService: ViewOnlyLinkHelperMockType; | ||
|
|
||
| const encodedDownloadUrl = 'https://files.osf.io/v1/resources/abc/providers/osfstorage/file.txt'; | ||
| const defaultRenderLink = `https://mfr.osf.io/render?url=${encodeURIComponent(encodedDownloadUrl)}`; | ||
|
|
||
| function buildFileDetailsModel(renderLink: string): FileDetailsModel { | ||
| return { | ||
| id: 'file-1', | ||
| guid: 'file-guid-1', | ||
| name: 'file.txt', | ||
| kind: FileKind.File, | ||
| path: '/file.txt', | ||
| size: 128, | ||
| materializedPath: '/file.txt', | ||
| dateModified: '2026-01-01T00:00:00.000Z', | ||
| dateCreated: '2026-01-01T00:00:00.000Z', | ||
| lastTouched: null, | ||
| tags: [], | ||
| currentVersion: 1, | ||
| showAsUnviewed: false, | ||
| extra: { | ||
| hashes: { | ||
| md5: 'md5', | ||
| sha256: 'sha256', | ||
| }, | ||
| downloads: 1, | ||
| }, | ||
| links: { | ||
| info: '', | ||
| move: '', | ||
| upload: '', | ||
| delete: '', | ||
| download: '', | ||
| render: renderLink, | ||
| html: '', | ||
| self: '', | ||
| }, | ||
| target: {} as unknown as BaseNodeModel, | ||
| }; | ||
| } | ||
|
|
||
| const defaultSignals: SignalOverride[] = [ | ||
| { selector: FilesSelectors.isOpenedFileLoading, value: false }, | ||
| { selector: FilesSelectors.getOpenedFile, value: buildFileDetailsModel(defaultRenderLink) }, | ||
| ]; | ||
|
|
||
| function setup(overrides: SetupOverrides = {}) { | ||
| const route = ActivatedRouteMockBuilder.create() | ||
| .withParams(overrides.routeParams ?? { fileGuid: 'file-1' }) | ||
| .build(); | ||
| mockRouter = RouterMockBuilder.create().withUrl('/files/file-1/preview').build(); | ||
| viewOnlyService = ViewOnlyLinkHelperMock.simple(overrides.hasViewOnlyParam ?? false); | ||
| viewOnlyService.getViewOnlyParam = vi.fn().mockReturnValue(overrides.viewOnlyParam ?? null); | ||
|
|
||
| const signals = mergeSignalOverrides(defaultSignals, [ | ||
| { | ||
| selector: FilesSelectors.getOpenedFile, | ||
| value: buildFileDetailsModel(overrides.renderLink ?? defaultRenderLink), | ||
| }, | ||
| ...(overrides.selectorOverrides ?? []), | ||
| ]); | ||
|
|
||
| TestBed.configureTestingModule({ | ||
| imports: [FilePreviewComponent], | ||
| providers: [ | ||
| provideOSFCore(), | ||
| MockProvider(ActivatedRoute, route), | ||
| MockProvider(Router, mockRouter), | ||
| MockProvider(ViewOnlyLinkHelperService, viewOnlyService), | ||
| provideMockStore({ signals }), | ||
| ], | ||
| }); | ||
|
|
||
| store = TestBed.inject(Store); | ||
| fixture = TestBed.createComponent(FilePreviewComponent); | ||
| component = fixture.componentInstance; | ||
| fixture.detectChanges(); | ||
| } | ||
|
|
||
| it('should create', () => { | ||
| setup(); | ||
|
|
||
| expect(component).toBeTruthy(); | ||
| }); | ||
|
|
||
| it('should dispatch get file action with route file guid on init', () => { | ||
| setup(); | ||
|
|
||
| expect(store.dispatch).toHaveBeenCalledWith(new GetFile('file-1')); | ||
| }); | ||
|
|
||
| it('should keep mfr url unchanged when render link has no nested url param', () => { | ||
| setup({ renderLink: 'https://mfr.osf.io/render' }); | ||
| (store.dispatch as Mock).mockClear(); | ||
|
|
||
| const result = component.getMfrUrlWithVersion('2'); | ||
|
|
||
| expect(result).toBe('https://mfr.osf.io/render'); | ||
| expect(store.dispatch).not.toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('should append version param to nested download url', () => { | ||
| setup(); | ||
|
|
||
| const result = component.getMfrUrlWithVersion('3'); | ||
|
|
||
| expect(result).toContain('https://mfr.osf.io/render?'); | ||
| expect(result).toContain(encodeURIComponent('version=3')); | ||
| }); | ||
|
|
||
| it('should append view only param when present', () => { | ||
| setup({ hasViewOnlyParam: true, viewOnlyParam: 'view-token-1' }); | ||
|
|
||
| const result = component.getMfrUrlWithVersion(); | ||
|
|
||
| expect(result).toContain(encodeURIComponent('view_only=view-token-1')); | ||
| }); | ||
|
|
||
| it('should return null for empty render link', () => { | ||
| setup({ renderLink: '' }); | ||
|
|
||
| const result = component.getMfrUrlWithVersion(); | ||
|
|
||
| expect(result).toBeNull(); | ||
| }); | ||
| }); |
79 changes: 79 additions & 0 deletions
79
src/app/features/files/pages/file-preview/file-preview.component.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,79 @@ | ||
| import { createDispatchMap, select } from '@ngxs/store'; | ||
|
|
||
| import { TranslatePipe } from '@ngx-translate/core'; | ||
|
|
||
| import { switchMap } from 'rxjs'; | ||
|
|
||
| import { ChangeDetectionStrategy, Component, computed, DestroyRef, HostBinding, inject } from '@angular/core'; | ||
| import { takeUntilDestroyed } from '@angular/core/rxjs-interop'; | ||
| import { DomSanitizer, SafeResourceUrl } from '@angular/platform-browser'; | ||
| import { ActivatedRoute, Router } from '@angular/router'; | ||
|
|
||
| import { FilesSelectors, GetFile } from '@osf/features/files/store'; | ||
| import { LoadingSpinnerComponent } from '@osf/shared/components/loading-spinner/loading-spinner.component'; | ||
| import { SubHeaderComponent } from '@osf/shared/components/sub-header/sub-header.component'; | ||
| import { ViewOnlyLinkHelperService } from '@osf/shared/services/view-only-link-helper.service'; | ||
|
|
||
| @Component({ | ||
| selector: 'osf-draft-file-detail', | ||
| imports: [SubHeaderComponent, LoadingSpinnerComponent, TranslatePipe], | ||
| templateUrl: './file-preview.component.html', | ||
| styleUrl: './file-preview.component.scss', | ||
| changeDetection: ChangeDetectionStrategy.OnPush, | ||
| }) | ||
| export class FilePreviewComponent { | ||
| @HostBinding('class') classes = 'flex flex-column flex-1 w-full h-full'; | ||
|
|
||
| private readonly router = inject(Router); | ||
| private readonly route = inject(ActivatedRoute); | ||
| private readonly sanitizer = inject(DomSanitizer); | ||
| private readonly destroyRef = inject(DestroyRef); | ||
| private readonly viewOnlyService = inject(ViewOnlyLinkHelperService); | ||
|
|
||
| private readonly actions = createDispatchMap({ getFile: GetFile }); | ||
|
|
||
| file = select(FilesSelectors.getOpenedFile); | ||
| isFileLoading = select(FilesSelectors.isOpenedFileLoading); | ||
|
|
||
| isIframeLoading = true; | ||
| safeLink: SafeResourceUrl | null = null; | ||
|
|
||
| hasViewOnly = computed(() => this.viewOnlyService.hasViewOnlyParam(this.router)); | ||
|
|
||
| constructor() { | ||
| this.route.params | ||
| .pipe( | ||
| takeUntilDestroyed(this.destroyRef), | ||
| switchMap((params) => this.actions.getFile(params['fileGuid'])) | ||
| ) | ||
| .subscribe(() => this.getIframeLink('')); | ||
| } | ||
|
|
||
| getIframeLink(version: string) { | ||
| const url = this.getMfrUrlWithVersion(version); | ||
| if (url) { | ||
| this.safeLink = this.sanitizer.bypassSecurityTrustResourceUrl(url); | ||
| } | ||
| } | ||
|
|
||
| getMfrUrlWithVersion(version?: string): string | null { | ||
| const mfrUrl = this.file()?.links.render; | ||
| if (!mfrUrl) return null; | ||
| const mfrUrlObj = new URL(mfrUrl); | ||
| const encodedDownloadUrl = mfrUrlObj.searchParams.get('url'); | ||
| if (!encodedDownloadUrl) return mfrUrl; | ||
|
|
||
| const downloadUrlObj = new URL(decodeURIComponent(encodedDownloadUrl)); | ||
|
|
||
| if (version) downloadUrlObj.searchParams.set('version', version); | ||
|
|
||
| if (this.hasViewOnly()) { | ||
| const viewOnlyParam = this.viewOnlyService.getViewOnlyParam(); | ||
| if (viewOnlyParam) downloadUrlObj.searchParams.set('view_only', viewOnlyParam); | ||
| } | ||
|
|
||
| mfrUrlObj.searchParams.set('url', downloadUrlObj.toString()); | ||
|
|
||
| return mfrUrlObj.toString(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.