[ENG-9957] Users unable to delete/remove files from draft registrations when starting from scratch#972
Open
mkovalua wants to merge 17 commits intoCenterForOpenScience:feature/pbs-26-9from
Open
Conversation
nsemets
approved these changes
Apr 29, 2026
nsemets
reviewed
Apr 29, 2026
nsemets
requested changes
Apr 30, 2026
| setMoveDialogCurrentFolder = output<FileFolderModel>(); | ||
| deleteEntryAction = output<string>(); | ||
| deleteEntryAction = output<FileModel>(); | ||
| removeFromAttachedFiles = output<FileModel>(); |
Collaborator
There was a problem hiding this comment.
Remove it, as it’s not used. removeFromAttachedFiles = output<FileModel>();
nsemets
previously approved these changes
Apr 30, 2026
brianjgeiger
previously approved these changes
Apr 30, 2026
nsemets
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Users should be able to remove or delete files from a registration draft.
Summary of Changes
created from the following one not merged yet PR to keep related files changings
#957
add delete file option for draft registration
4f36-9773-4d13-a058-fdd91b2cf244.mp4
Screenshot(s)
Side Effects
QA Notes