Fix stuck chat + freezed view - #2533
1 potential issue found
Incremental Code Review Summary
The latest commit fixes the previously reported dependency issue by adding the derived awaitingResponse value to the RunStuckBanner auto-retry effect dependencies. I verified the idle-chat gate, the MultiTabAssistantChat isRunning() wiring, the separated automatic-retry/busy state, and the Radix override and lockfile consistency. The focused agent reviews found no additional correctness, security, or performance problems beyond the new UX issue below. The prior review comment was verified fixed and has been resolved.
Key Findings
🟡 MEDIUM: After an automatic retry settles without changing the run ID, the controls become enabled but autoRetriedRunId remains set. If the user then clicks manual Retry, the banner continues to say “Retrying automatically now.” while the user-initiated request is in progress. Clear the automatic marker when starting manual Retry or include the busy state in the message condition.
🧪 Browser testing: Planned but could not execute — all executor sessions lacked browser automation tools after retry; the dev server was healthy and /content and /chat were reachable.