Skip to content

Added ARG query to A01.31 in afd_checklist.en.json #929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asukumar22 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Added ARG query to A01.31 in afd_checklist.en.json #929

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0d78e7
Added ARG query to A01.31 in afd_checklist.en.json
asukumar22 Sep 26, 2024
93a4a56
Updated review comments in afd_checklist.en.json
asukumar22 Sep 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion checklists/afd_checklist.en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@
"guid": "147a13d4-2a2f-4824-a524-f5855b52b946",
"id": "A01.31",
"severity": "High",
"graph" : "resources| where type == "microsoft.network/frontdoorwebapplicationfirewallpolicies"| where properties['managedRules']['managedRuleSets'][1]['ruleSetType'] =~ "Microsoft_BotManagerRuleSet"| extend compliant = properties['managedRules']['managedRuleSets'][1]['ruleSetType'] =~ "Microsoft_BotManagerRuleSet"| distinct id,name,compliant",
Copy link
Copy Markdown
Collaborator

@erjosito erjosito Sep 26, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use single quotes (instead of double quotes) inside of the ARG query string

"link": "https://learn.microsoft.com/azure/web-application-firewall/afds/waf-front-door-best-practices#enable-bot-management-rules"
},
{
Expand Down Expand Up @@ -514,4 +515,4 @@
"waf": "all",
"timestamp": "September 23, 2024"
}
}
}