Skip to content

Added ARG query to A01.31 in afd_checklist.en.json#929

Open
asukumar22 wants to merge 2 commits intoAzure:mainfrom
asukumar22:patch-17
Open

Added ARG query to A01.31 in afd_checklist.en.json#929
asukumar22 wants to merge 2 commits intoAzure:mainfrom
asukumar22:patch-17

Conversation

@asukumar22
Copy link
Copy Markdown
Contributor

@asukumar22 asukumar22 commented Sep 26, 2024

Added ARG query to A01.31 in afd_checklist.en.json

Description

Please provide a detailed description of your changes.

Related Issue

Link to any related issues or discussions here. This helps reviewers understand the context and the need for your changes.

Checklist

  • I've tested my changes to ensure they are ready for review.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the documentation (if applicable).
  • Resource Graph queries have been included (and tested) for recommendations where ever possible1.
  • Resource Graph queries have NOT been included (please explain below).

Additional Information

Is there any additional context, screenshots, or considerations that might help in the review process? Please include them here.

Reviewer Notes

Is there a specific area you’d like feedback on? Please highlight it here. We're here to help and learn together! 💡

Footnotes

  1. Details on how to add Azure Resource Graph queries to recommendations can be found here.

Added ARG query to A01.31 in afd_checklist.en.json
Comment thread checklists/afd_checklist.en.json Outdated
"guid": "147a13d4-2a2f-4824-a524-f5855b52b946",
"id": "A01.31",
"severity": "High",
"graph" : "resources| where type == "microsoft.network/frontdoorwebapplicationfirewallpolicies"| where properties['managedRules']['managedRuleSets'][1]['ruleSetType'] =~ "Microsoft_BotManagerRuleSet"| extend compliant = properties['managedRules']['managedRuleSets'][1]['ruleSetType'] =~ "Microsoft_BotManagerRuleSet"| distinct id,name,compliant",
Copy link
Copy Markdown
Collaborator

@erjosito erjosito Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use single quotes (instead of double quotes) inside of the ARG query string

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants