Skip to content

Accept --wp auto-update as the CLI name for the auto-update mode - #4750

Merged
gcsecsey merged 2 commits into
trunkfrom
gcsecsey/accept-auto-update-wp-value
Sep 3, 2026
Merged

Accept --wp auto-update as the CLI name for the auto-update mode#4750
gcsecsey merged 2 commits into
trunkfrom
gcsecsey/accept-auto-update-wp-value

Conversation

@gcsecsey

@gcsecsey gcsecsey commented Sep 1, 2026

Copy link
Copy Markdown
Member

Related issues

How AI was used in this PR

I used Opus 5 for implementation and tests.

Proposed Changes

#4702 renames the "latest" WordPress version option to "Auto-update" in both UIs. This PR updates the naming in the CLI to keep it consistent.

--wp auto-update now selects that mode, matching what the apps show. --wp latest keeps working as an alias too, so existing scripts and blueprints are unaffected.

latest is still the internal value, and it still names a cache directory, a segment of the wordpress.org download URL, and the persisted site setting. The alias is resolved where the CLI parses input and never reaches storage.

Two side effects:

  • blueprint use --wp was not validated at all. It needed the alias mapping anyway, and the shared coercion brings validation with it, so a bad value now fails at parse time instead of throwing from inside the download helper.
  • The interactive version picker in site create said latest (7.1); it now says Auto-update (7.1), matching the apps.

Testing Instructions

  • Build the CLI with npm run cli:build

The new value works

node apps/cli/dist/cli/main.mjs site create --path ~/Studio/wp-alias --name wp-alias --wp auto-update --no-start
  • check ~/.studio/cli.json: the site should have "isWpAutoUpdating": true.
CleanShot 2026-09-01 at 17 00 38@2x

latest still works

node apps/cli/dist/cli/main.mjs site start --path ~/Studio/wp-alias
node apps/cli/dist/cli/main.mjs config set --path ~/Studio/wp-alias --wp 6.9
node apps/cli/dist/cli/main.mjs config set --path ~/Studio/wp-alias --wp latest
--wp 6.9 --wp latest
CleanShot 2026-09-01 at 17 14 59@2x CleanShot 2026-09-01 at 17 16 21@2x

isWpAutoUpdating should go false, then back to true. The site has to be running
for config set --wp to apply, so studio start it first.

Help text

site create --help, config set --help and blueprint use --help should all
describe auto-update and mention that latest is accepted.

CleanShot 2026-09-01 at 17 17 12@2x

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The agent-facing skill update lacks required eval coverage, and its validation message omits the supported latest alias.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 6/6 changed files
  • Comments generated: 2
  • Review effort level: Balanced

Comment thread apps/cli/lib/wp-version-option.ts
Comment thread skills/studio-cli/SKILL.md Outdated
Comment thread apps/cli/lib/wp-version-option.ts Outdated
Base automatically changed from gcsecsey/wordpress-version-expectation to trunk September 3, 2026 11:18
@gcsecsey
gcsecsey force-pushed the gcsecsey/accept-auto-update-wp-value branch from 0674edb to 537ba04 Compare September 3, 2026 11:18
@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 537ba04 vs trunk

app-size

Metric trunk 537ba04 Diff Change
App Size (Mac) 1425.95 MB 1425.96 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk 537ba04 Diff Change
load 1181 ms 1244 ms +63 ms 🔴 5.3%

site-startup

Metric trunk 537ba04 Diff Change
siteCreation 7525 ms 7532 ms +7 ms ⚪ 0.0%
siteStartup 2871 ms 2885 ms +14 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@gcsecsey
gcsecsey merged commit 9b494ff into trunk Sep 3, 2026
13 checks passed
@gcsecsey
gcsecsey deleted the gcsecsey/accept-auto-update-wp-value branch September 3, 2026 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants