Split the WordPress version setting into an update mode and a version picker - #4752
Open
gcsecsey wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The automatic-update description is not programmatically associated with its radio control for screen-reader users.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Splits the Agentic UI’s WordPress setting into update mode and pinned-version controls.
Changes:
- Adds automatic-update and version-selection radio choices.
- Handles unknown and unavailable versions safely.
- Adds responsive styling, dark-theme colors, and focused tests.
File summaries
| File | Description |
|---|---|
apps/ui/src/index.css |
Styles radio controls across themes. |
apps/ui/src/components/site-overview-view/index.test.tsx |
Tests settings interactions and edge cases. |
apps/ui/src/components/site-fields/wp-version-control.tsx |
Implements the split controls. |
apps/ui/src/components/site-fields/style.module.css |
Lays out the new controls. |
apps/ui/src/components/site-fields/index.ts |
Builds current and unknown version options. |
apps/ui/src/components/site-fields/index.test.ts |
Tests generated version options. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
gcsecsey
marked this pull request as ready for review
September 2, 2026 15:18
1 task
Contributor
Contributor
|
Mostly, we should be aiming towards an end state as shown in #4747
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Related issues
How AI was used in this PR
I used Opus 5 for implementation and tests.
Proposed Changes
The WordPress version setting mixes two decisions: whether the site updates itself, and which version it is pinned to. #4702 fixes the wording of the single dropdown, but the two decisions still share one control.
This PR splits them into an
Automatic updatestoggle and a version picker that's only shown when the toggle is off, so the picker only ever means "pin this version". While auto-update is on, the field reports the version the site runs.Testing Instructions
Automatic updatesis on, the field showsInstalled version: <version>.Versionpicker appears, preselected to the version the site runsSave settingsbecomes enabledPre-merge Checklist