Design exploration: Clarify Agentic UI site settings - #4747
Draft
shaunandrews wants to merge 2 commits into
Draft
Conversation
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Codex was used as an implementation and design-prototyping partner. The interaction model, hierarchy, wording, spacing, responsive behavior, dark-mode treatment, and disabled states were iterated through direct human review in the running Agentic UI. Codex also updated focused tests and prepared the review evidence; the design decisions came from that review loop.
Executive summary
The existing
latestWordPress version value mixes two concepts: the version currently installed and whether WordPress should update itself. This draft separates those decisions in the Agentic UI so users can choose Automatic updates or Select a version, while still seeing the installed version.The exploration also uses the settings redesign to restore currently missing Agentic UI controls for PHP runtime and file access, improve grouping and scanability, and keep the save action reachable as the settings surface grows.
This is a draft design exploration. It is intentionally separate from #4702 so that PR can continue to represent Gergely's narrower wording approach.
Proposed Changes
Review guide
1. WordPress update model
Please focus first on whether Automatic updates and Select a version correctly express the two user intents. Automatic mode reports the installed version; pinned mode exposes the same compact picker at all times. This deliberately avoids hiding controls or encoding update mode in a version named
latest.2. Settings hierarchy and density
The form stays in a centered 560px column rather than expanding into multiple columns at wide widths. Section headings and separators establish hierarchy; related controls remain visible without accordions or secondary screens.
3. Runtime and file-access dependency
PHP runtime and file access now have parity with the underlying site settings. Selecting Sandbox forces Site directory access. The file-access choices remain visible but disabled, accompanied by a neutral WPDS notice and the tooltip “Requires the Native PHP runtime”.
4. Persistent actions and responsive behavior
Save settings is portaled into the existing footer toolbar. Review the footer with the preview open and closed, and with the sidebar expanded and collapsed. It should remain reachable without covering the final form content.
5. Data path
Runtime and file-access values travel through the shared
SiteDetailsshape and the local connector's existingsite setargument builder. Sandbox normalization happens before the update is sent. There is no persistence migration.Okay to skim
Versionselect.Known tradeoffs and follow-ups
@wordpress/components; this draft uses it to evaluate the intended design-system direction.Safety checklist
formattributeScreenshots
Wide layout with preview open
The settings column keeps a stable readable width while the site preview uses the remaining space.
Narrow layout and sticky footer
The footer keeps Save settings visible at the bottom. With the sidebar collapsed, its toggle and the save action no longer overlap:
WordPress update choices
Sandbox and file access
Disabled choices use a not-allowed cursor and explain the dependency on hover or keyboard focus:
RTL and mixed-direction content
The Hebrew pass verifies mirrored layout, physical control order, compact select alignment, footer placement, and punctuation direction in untranslated English fallback copy.
Testing Instructions
Automated checks run:
npm run typecheck npm test -- apps/ui/src/components/site-settings-view/index.test.tsx apps/ui/src/components/site-overview-view/index.test.tsx npm run cli:build:uiResults:
Manual verification:
studio ui, then open an existing site's Settings tab.Pre-merge Checklist