Skip to content

Create A-Game-Of-Thrones.json #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
k1dnyy wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create A-Game-Of-Thrones.json #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions books/A-Game-Of-Thrones.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
{
"title": "A Game Of Thrones",
"storyline": "A Game of Thrones takes place over the course of one year on or near the fictional continent of Westeros. The story begins when King Robert visits the northern castle Winterfell to ask Ned Stark to be his right-hand assistant, or Hand of the King. The previous Hand, Jon Arryn, died under suspicious circumstances.",
"authors": ["George R.R. Martin"],
"genres": "Poilitical novel, Epic Fantasy",

@niftytushar niftytushar Oct 9, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k1dnyy genres should have been an array.
Refer:

books-db/books/neuromancer.json

Line 5 in a5db372

"genres": [

"characters": "Eddard Ned Stark, Catelyn Stark, Sansa Stark, Arya Stark, Bran Stark, Jon Snow, Tyrion Lannister, Queen Cersei, Jamie, Tywin Lannister, Daenerys Targaryen, Viserys Targaryen ",

@niftytushar niftytushar Oct 9, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

characters should have been an array.
Refer:

books-db/books/neuromancer.json

Line 9 in a5db372

"characters": ["Henry Dorsett Case"],

"pages": 694,
"ISBN": "0553103547",
"language": "english",
"publisher": "Bantam Spectra",
"publication_date": "1996-08-01"
}