Create A-Game-Of-Thrones.json - #81
Open
k1dnyy wants to merge 1 commit into
Open
Conversation
A Game Of Thrones added to .json book database 👍
niftytushar
requested changes
Oct 9, 2019
| "title": "A Game Of Thrones", | ||
| "storyline": "A Game of Thrones takes place over the course of one year on or near the fictional continent of Westeros. The story begins when King Robert visits the northern castle Winterfell to ask Ned Stark to be his right-hand assistant, or Hand of the King. The previous Hand, Jon Arryn, died under suspicious circumstances.", | ||
| "authors": ["George R.R. Martin"], | ||
| "genres": "Poilitical novel, Epic Fantasy", |
Member
There was a problem hiding this comment.
@k1dnyy genres should have been an array.
Refer:
books-db/books/neuromancer.json
Line 5 in a5db372
| "storyline": "A Game of Thrones takes place over the course of one year on or near the fictional continent of Westeros. The story begins when King Robert visits the northern castle Winterfell to ask Ned Stark to be his right-hand assistant, or Hand of the King. The previous Hand, Jon Arryn, died under suspicious circumstances.", | ||
| "authors": ["George R.R. Martin"], | ||
| "genres": "Poilitical novel, Epic Fantasy", | ||
| "characters": "Eddard Ned Stark, Catelyn Stark, Sansa Stark, Arya Stark, Bran Stark, Jon Snow, Tyrion Lannister, Queen Cersei, Jamie, Tywin Lannister, Daenerys Targaryen, Viserys Targaryen ", |
Member
There was a problem hiding this comment.
characters should have been an array.
Refer:
books-db/books/neuromancer.json
Line 9 in a5db372
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Game Of Thrones added to .json book
database 👍
Proposed Changes
Fixes issue
Fixes #74