fix: Use relaxed firewall only for routed request#4643
Open
pavel-jares-bcm wants to merge 3 commits into
Open
Conversation
achmelo
reviewed
May 26, 2026
| private static final String[] BASE_PATHS_MODULITH = ArrayUtils.addAll(BASE_PATH_MICROSERVICES, new String[] { | ||
| "/discovery", | ||
| "/apicatalog", | ||
| "/cachingservice" |
Contributor
Author
There was a problem hiding this comment.
zaas is not routable (there is no endpoint). It is valid also for discovery (removed) and eureka is on another port. If these basePath would be used it will be processed as routable (service could have such a serviceId even it is strage)
Signed-off-by: Pavel Jareš <Pavel.Jares@broadcom.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
Currently the whole services uses a relaxed firewalls. It is based on an original issue #23. Some services requires to provide these type of URLs. Anyway, it is valid only for gateway - the routing part. For the rest of the endpoints there could be use a strict firewall. This PR allows to define relaxed one only for proxying.
Linked to # (issue)
Part of the # (epic)
Type of change
Please delete options that are not relevant.
Checklist:
For more details about how should the code look like read the Contributing guideline