Repository navigation
feat(proxy): expose tls-staging and reader/writer-affinity deploy flags in deploy.yml - #20
Merged
Merged
Conversation
…gs in deploy.yml ## Summary kamal-proxy supports --tls-staging, --read-target, --read-target-websockets and --writer-affinity-timeout on deploy, but none had a deploy.yml surface. Add proxy.ssl_staging (named after the ssl_redirect -> --tls-redirect precedent), read_targets, read_target_websockets and writer_affinity_timeout, emitted via Proxy#deploy_options. All keys optional; nothing is emitted when unset, so existing configs are unchanged. ## Test Coverage - all four flags emitted (repeated --read-target, s-suffixed duration) - absent when unset; false booleans emit no flag (proxy defaults) - --read-target present in deploy_command_args output - type rejections via the docs schema (bool/array/integer) ## Verification - [x] bundle exec rubocop --parallel passes - [x] unit suite: 842 runs, only the two known Apple-Silicon builder failures Fixes #5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proxy:—ssl_staging,read_targets,read_target_websockets,writer_affinity_timeout— mapped to kamal-proxy's--tls-staging,--read-target,--read-target-websockets,--writer-affinity-timeoutinProxy#deploy_optionsssl_stagingfollows thessl_redirect->--tls-redirectnaming precedent;writer_affinity_timeouttakes seconds and emits<n>slib/kamal/configuration/docs/proxy.yml(which also drives schema/type validation — no custom validator rules needed)mainand stays upstream-PR-ableProxy#deploy_optionsreuse from fix(loadbalancer): propagate full proxy deploy options to the LB #14 —ssl_stagingreaching the LB is the P0 piece for safe cert-cutover rehearsalFixes #5
Test plan
bundle exec rubocop --parallel— no offenses