Skip to content

R1: Fix bind_ips validator checking the wrong config key #2

Closed
#19
Closed
R1: Fix bind_ips validator checking the wrong config key#2
#19
Labels
bugSomething isn't workinggemLegacy: the gem side of cross-repo work (every item in this repo is)size:SSmall: hours
Milestone
R1 — Foundations & fixes

Description

@mhenrixon
mhenrixon
opened on Jul 3, 2026

The proxy validator checks config["bind_ips"] (root) but the value actually lives at run.bind_ips, so validation is a no-op for the nested key.

Anchor: lib/kamal/configuration/validator/proxy.rb:27-28.

Verify: a proxy.run.bind_ips with an invalid IP now raises a ConfigurationError; add a unit test.

Activity

  1. mhenrixon
    added this to the R1 — Foundations & fixes milestone on Jul 3, 2026
  2. mhenrixon
    added
    gemLegacy: the gem side of cross-repo work (every item in this repo is)
    size:SSmall: hours
    bugfix
    on Jul 3, 2026
  3. mhenrixon
    added a parent issue on Jul 3, 2026
  4. mhenrixon
    closed this as completedin a69ee15on Jul 11, 2026
  5. mhenrixon
    added a commit that references this issue on Jul 11, 2026

    Merge fix/bind-ips-validator into dash

    4b5cbb7
  6. mhenrixon
    added
    bugSomething isn't working
    and removed
    bugfix
    on Oct 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggemLegacy: the gem side of cross-repo work (every item in this repo is)size:SSmall: hours

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions