Support ESM in configs and plugins#1383
Open
zodern wants to merge 9 commits into
Open
Conversation
Owner
Author
|
Lint will fail since the old version of eslint we use doesn't support top level await. Eslint will be updated in another PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes babel, and fully migrates to ESM (except for the e2e tests, which are still cjs so we can use mocha's watch feature).
ESM and top level await is supported in configs. This allows config files to use async api's to create the config, such as loading a list of servers from the digital ocean api, or using a secret manager to get the env variables.
Plugins can also use ESM.