Handle empty upgrade metadata in GetLightdInfo#1071
Open
Zk-nd3r wants to merge 1 commit intozingolabs:devfrom
Open
Handle empty upgrade metadata in GetLightdInfo#1071Zk-nd3r wants to merge 1 commit intozingolabs:devfrom
Zk-nd3r wants to merge 1 commit intozingolabs:devfrom
Conversation
227784d to
8a708fa
Compare
Contributor
|
utACK (Thanks for finding and fixing this, and helping to make Zaino stronger!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This replaces the
GetLightdInfoempty-upgrades panic path with afailed_preconditionservice error.Changes
Context
This is the first single-concern issue/PR pair from the Zaino findings list. Kept narrow on purpose so it can fit your normal review and test policy before I split out the rest.
Testing
cargo +stable fmt --all --checkgit diff --checkCould not run the targeted Rust test on this Windows host because the local GNU toolchain is missing
dlltool.exe; build stops in dependency compile before reachingzaino-state.Closes #1070