Align CompactTxStreamer responses with lightwalletd#1067
Open
pacu wants to merge 3 commits intozingolabs:devfrom
Open
Align CompactTxStreamer responses with lightwalletd#1067pacu wants to merge 3 commits intozingolabs:devfrom
pacu wants to merge 3 commits intozingolabs:devfrom
Conversation
7 tasks
pacu
force-pushed
the
lightwalletd-compact-block-parity
branch
from
c5b27c8 to
88899ec
Compare
Align Zaino's CompactTxStreamer responses with lightwalletd for single-block lookups. GetBlock and GetBlockNullifiers now request all pool data, compact blocks use lightwalletd's protoVersion value, nullifier responses clear transparent inputs and outputs, and tree-state RPCs are delegated to the backing validator so they are not limited by the local cache view.
Teach the chain index to reconstruct compact blocks from the backing validator when a serviceable non-finalized height is absent from the local snapshot/finalized DB. This matches lightwalletd's validator-backed behavior for recently loaded chains and prevents GetBlock/GetBlockRange from reporting database holes while Zaino's local cache is still catching up.
Restore local chain-index tree-state lookup as the primary path, and only fall back to the backing validator when the local data cannot serve the request. This keeps Zaino's local-data semantics while preserving the boot/cache-miss behavior needed for lightwalletd parity in the gRPC comparison test.
pacu
force-pushed
the
lightwalletd-compact-block-parity
branch
from
88899ec to
e09ff2e
Compare
Contributor
Author
|
This branch succeeds against this branch of integration tests zcash/integration-tests#84 |
Member
|
Can you please run:
There might be flakes that need more than one run in the integration tests.. stable..... |
Contributor
Author
I found some errors within the containerized setup which I'm fixing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: this is a draft PR since the
protoVersionpart is yet to be defined.Fixes:
Summary
Align Zaino CompactTxStreamer compact block responses with lightwalletd for the fields covered by the strict integration-tests gRPC comparison suite.
This PR:
GetBlockresponsesprotoVersionvalues in compact blocksvin/voutinGetBlockNullifiersVerification
cargo build --release --bin zainodtimeout 600s uv run ./qa/zcash/grpc_comparison_tests.pyfromzcash/integration-testsCloses #1066