Conversation
idky137
changed the title
pacu
reviewed
Apr 27, 2026
…_test_prerequisite_t_address_rpcs
Contributor
Author
|
NOTE: This is ready for review but I have not managed to test this end-to-end locally as the integration tests are not passing on my machine. This behaviour is present on dev so not related to this PR, but a separate change made over the last few weeks (unknown). (#1073) |
3 tasks
…_test_prerequisite_t_address_rpcs
AloeareV
approved these changes
Apr 28, 2026
Contributor
AloeareV
left a comment
AloeareV
left a comment
There was a problem hiding this comment.
Reapproving after some clippy fixes
zancas
added a commit
that referenced
this pull request
Apr 30, 2026
… split merge
· esc to interrupt
The merge from `dev` (#1065) split `chain_index/source.rs` into a `source/`
directory without reconciling this branch's #1037 / mempool_skew work, which
had been written against the old layout. Restore the dropped pieces on
`source/mockchain_source.rs`:
* `mine_blocks_silent` and `active_block_hash` inherent methods, lifted
from a5ff985 / 934ce01.
* `change_broadcast` field + init in both ctors, `mine_blocks` send on
actual advance, and the `change_subscribe` override — the broadcast
plumbing 901afc1 added on the old `source.rs`. Without it,
`mine_blocks` and `mine_blocks_silent` were behaviourally identical
and consumers fell through to the trait default's `None`.
Fix `tests/mockchain_tests.rs`: import `BlockchainSource` (t-address RPCs
became trait methods in #1065) and `GetAddressDeltasParams` / `Response`.
Add a regression test adjacent to the methods (`mod mine_blocks`) pinning
the broadcast contract directly, so future drift surfaces at the source
instead of as flake in the skew tests.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sub-tasks / status:
get_raw_transactionimplementation in backends::{fetch::FetchService, state::StateService} (required as this is used by the transparent address history methods, functionality already present in ChainIndex, just not wired in).NOTE: 58ca906 does not contain any code changes, it only moves current code in source.rs into sub-modules. To view the true code diff exclude this commit from the diff view. This artificially inflates the size (line changes) of this PR.