Skip to content

helperize shutdown signal #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AloeareV merged 9 commits into from
Apr 29, 2026
+13 −10
Merged

helperize shutdown signal #1054

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bcb6084
● refactor(zaino-state): extract shared DbLifecycle trait from DbV0/D…
zancas Apr 24, 2026
11321da
remove insufficiently stable tests from 'stable' profile
zancas Apr 24, 2026
f2f8cc1
● test(zaino-state): add failing regression for #1033 shutdown_notify…
zancas Apr 24, 2026
07c93fd
● fix(zaino-state): use CancellationToken for shutdown signaling (#1033)
zancas Apr 24, 2026
6bbd8fd
remove insufficiently stable
zancas Apr 24, 2026
13fed74
● refactor(zaino-serve): extract jsonrpc shutdown_signal closure (#1052)
zancas Apr 24, 2026
b134c66
Merge branch 'dev' into use_CT_in_jsonrpc
zancas Apr 27, 2026
7be0857
Merge branch 'dev' into use_CT_in_jsonrpc
zancas Apr 27, 2026
6fe6f65
Merge branch 'dev' into use_CT_in_jsonrpc
AloeareV Apr 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions packages/zaino-serve/src/server/jsonrpc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,16 +83,7 @@ impl JsonRpcServer {

let server_handle = server.start(rpc_impl.into_rpc());

let shutdown_check_status = status.clone();
let mut shutdown_check_interval = interval(Duration::from_millis(100));
let shutdown_signal = async move {
loop {
shutdown_check_interval.tick().await;
if shutdown_check_status.load() == StatusType::Closing {
break;
}
}
};
let shutdown_signal = shutdown_signal(status.clone());

let task_status = status.clone();
let server_task_handle = tokio::task::spawn({
Expand Down Expand Up @@ -150,3 +141,15 @@ impl Drop for JsonRpcServer {
}
}
}

async fn shutdown_signal(
status: NamedAtomicStatus,
) {
let mut shutdown_check_interval = interval(Duration::from_millis(100));
loop {
shutdown_check_interval.tick().await;
if status.load() == StatusType::Closing {
break;
}
}
}
Loading