Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/app/Packages/Features/Controller/FavoriteController.php
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,38 @@

use App\Http\Controllers\Controller;
use App\Packages\Features\CommandUseCases\UseCase\Favorite\AddFavoriteUseCase;
use App\Packages\Features\QueryUseCases\UseCase\Favorite\GetFavoriteHeritagesUseCase;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Log;
use Throwable;

class FavoriteController extends Controller
{
public function getFavorites(
Request $request,
GetFavoriteHeritagesUseCase $useCase,
): JsonResponse {
try {
$dtoCollection = $useCase->handle($request->user()->id);

return response()->json([
'status' => 'success',
'data' => $dtoCollection->toSummaryArray(),
], 200);
} catch (Throwable $throwable) {
Log::error('Failed to get favorites', [
'message' => $throwable->getMessage(),
'trace' => $throwable->getTraceAsString(),
]);

return response()->json([
'status' => 'error',
'message' => 'Internal Server Error',
], 500);
}
}

public function addFavorite(
Request $request,
AddFavoriteUseCase $useCase,
Expand Down
77 changes: 77 additions & 0 deletions src/app/Packages/Features/Tests/FavoriteControllerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@
use App\Models\User;
use App\Models\WorldHeritage;
use App\Packages\Domains\Favorite\Interface\FavoriteRepositoryInterface;
use App\Packages\Domains\WorldHeritage\Ports\Dto\HeritageSearchResult;
use App\Packages\Domains\WorldHeritage\Ports\WorldHeritageSearchPort;
use App\Packages\Features\CommandUseCases\UseCase\Favorite\AddFavoriteUseCase;
use App\Packages\Features\QueryUseCases\QueryServiceInterface\WorldHeritageQueryServiceInterface;
use App\Packages\Features\QueryUseCases\UseCase\Favorite\GetFavoriteHeritagesUseCase;
use Illuminate\Support\Facades\DB;
use Mockery;
use RuntimeException;
Expand All @@ -17,6 +21,15 @@ protected function setUp(): void
{
parent::setUp();
$this->truncate();

$this->app->bind(WorldHeritageSearchPort::class, static function () {
return new class implements WorldHeritageSearchPort {
public function search($query, int $currentPage, int $perPage): HeritageSearchResult
{
return new HeritageSearchResult(ids: [], total: 0, currentPage: 1, perPage: $perPage, lastPage: 0);
}
};
});
}

protected function tearDown(): void
Expand Down Expand Up @@ -110,4 +123,68 @@ public function test_addFavorite_returns_500_on_unexpected_error(): void
'message' => 'Internal Server Error',
]);
}

public function test_getFavorites_returns_200_with_favorite_heritages_when_authenticated(): void
{
$user = $this->seedUser();
$worldHeritage1 = $this->seedWorldHeritage(1);
$worldHeritage2 = $this->seedWorldHeritage(2);
$token = $user->createToken('auth-token')->plainTextToken;

$user->favorites()->attach($worldHeritage1->id);
$user->favorites()->attach($worldHeritage2->id);

$response = $this->withToken($token)->getJson('/api/v1/favorites');

$response->assertStatus(200)
->assertJsonFragment(['status' => 'success'])
->assertJsonCount(2, 'data');

$ids = array_column($response->json('data'), 'id');
$this->assertEqualsCanonicalizing([$worldHeritage1->id, $worldHeritage2->id], $ids);
}

public function test_getFavorites_returns_200_with_empty_array_when_user_has_no_favorites(): void
{
$user = $this->seedUser();
$token = $user->createToken('auth-token')->plainTextToken;

$response = $this->withToken($token)->getJson('/api/v1/favorites');

$response->assertStatus(200)
->assertJsonFragment(['status' => 'success'])
->assertJsonCount(0, 'data');
}

public function test_getFavorites_returns_401_when_unauthenticated(): void
{
$response = $this->getJson('/api/v1/favorites');

$response->assertStatus(401);
}

public function test_getFavorites_returns_500_on_unexpected_error(): void
{
$user = $this->seedUser();
$token = $user->createToken('auth-token')->plainTextToken;

$favoriteRepository = Mockery::mock(FavoriteRepositoryInterface::class);
$favoriteRepository->shouldReceive('getFavoriteWorldHeritageIds')
->andThrow(new RuntimeException('Unexpected error'));

$worldHeritageQueryService = Mockery::mock(WorldHeritageQueryServiceInterface::class);

$this->app->instance(
GetFavoriteHeritagesUseCase::class,
new GetFavoriteHeritagesUseCase($favoriteRepository, $worldHeritageQueryService),
);

$response = $this->withToken($token)->getJson('/api/v1/favorites');

$response->assertStatus(500)
->assertJsonFragment([
'status' => 'error',
'message' => 'Internal Server Error',
]);
}
}
1 change: 1 addition & 0 deletions src/routes/api.php
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
});

Route::controller(FavoriteController::class)->prefix('favorites')->middleware('auth:sanctum')->group(function (): void {
Route::get('/', 'getFavorites');
Route::post('/', 'addFavorite');
});
});
Loading