feat: implement Infra and Application layers for favorite heritages list / お気に入り一覧のInfra・Application層実装 - #570
Merged
zigzagdev merged 4 commits intoAug 8, 2026
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/user-favorite #570 +/- ##
========================================================
+ Coverage 63.70% 64.05% +0.35%
- Complexity 1657 1671 +14
========================================================
Files 142 145 +3
Lines 8607 8694 +87
========================================================
+ Hits 5483 5569 +86
- Misses 3124 3125 +1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / 目的
Continue the favorite heritages list feature. This PR adds the pieces needed to turn a user's favorite ids into a displayable list of world heritages:
WorldHeritageQueryService::getHeritagesByIds(), reusing the existingfindByIdsPreserveOrder()+ payload/DTO pipeline already used bysearchHeritages().GetFavoriteHeritagesUseCase, which combinesFavoriteRepository::getFavoriteWorldHeritageIds()withgetHeritagesByIds()to return aWorldHeritageDtoCollectionfor a given user.Pagination is intentionally out of scope — it will be added later once needed.
What I have done / 実施内容
WorldHeritageQueryServiceInterface::getHeritagesByIds(array $ids): WorldHeritageDtoCollectionWorldHeritageQueryServiceGetFavoriteHeritagesUseCase::handle(int $userId): WorldHeritageDtoCollectionTest Results / テスト結果