Skip to content

feat: implement Infra layer for favorite heritages list (WorldHeritageQueryService) / お気に入り一覧のInfra層実装(WorldHeritageQueryService) - #569

Closed
zigzagdev wants to merge 2 commits into
feat/user-favoritefrom
feat/user-favorite-index-list-infra
Closed

feat: implement Infra layer for favorite heritages list (WorldHeritageQueryService) / お気に入り一覧のInfra層実装(WorldHeritageQueryService)#569
zigzagdev wants to merge 2 commits into
feat/user-favoritefrom
feat/user-favorite-index-list-infra

test: cover getHeritagesByIds in WorldHeritageQueryService

de8dc1a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 8, 2026 in 1s

63.89% (+0.19%) compared to b4acd34

View this Pull Request on Codecov

63.89% (+0.19%) compared to b4acd34

Details

Codecov Report

❌ Patch coverage is 97.95918% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.89%. Comparing base (b4acd34) to head (de8dc1a).
⚠️ Report is 1 commits behind head on feat/user-favorite.

Files with missing lines Patch % Lines
...orldHeritageQueryService_getHeritagesByIdsTest.php 97.67% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##             feat/user-favorite     #569      +/-   ##
========================================================
+ Coverage                 63.70%   63.89%   +0.19%     
- Complexity                 1657     1666       +9     
========================================================
  Files                       142      143       +1     
  Lines                      8607     8656      +49     
========================================================
+ Hits                       5483     5531      +48     
- Misses                     3124     3125       +1     
Files with missing lines Coverage Δ
...omains/WorldHeritage/WorldHeritageQueryService.php 96.56% <100.00%> (+0.08%) ⬆️
...orldHeritageQueryService_getHeritagesByIdsTest.php 97.67% <97.67%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.