Use RESCHEDULE source route discovery mode#716
Draft
TheJulianJES wants to merge 1 commit intozigpy:devfrom
Draft
Use RESCHEDULE source route discovery mode#716TheJulianJES wants to merge 1 commit intozigpy:devfrom
RESCHEDULE source route discovery mode#716TheJulianJES wants to merge 1 commit intozigpy:devfrom
Conversation
…ting
`SourceRouteDiscoveryMode.ON` only schedules the *periodic* MTORR; it
does not trigger an immediate broadcast. Devices joining or rejoining
during the first interval after startup therefore have no source-route
table entry on the NCP and fall back to AODV/route discovery — the
opposite of what enabling the concentrator is meant to achieve. With
`MTOR_MAX_INTERVAL` currently at 3600s, that gap can be up to an hour.
Per the SDK enum docs (`sl_zigbee_types.h` /
`ember-types.h`):
ON source routes discovery is scheduled, and it is
triggered periodically
RESCHEDULE source routes discoveries are re-scheduled to be sent
once immediately and then triggered periodically
zigbee-herdsman's ember adapter uses `RESCHEDULE` for this reason.
Switch bellows to match.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #716 +/- ##
=======================================
Coverage 99.54% 99.54%
=======================================
Files 61 61
Lines 4147 4147
=======================================
Hits 4128 4128
Misses 19 19 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT/TODO: Check if we want this at startup.
AI summary
SourceRouteDiscoveryMode.ONonly schedules the periodic MTORR; it does not trigger an immediate broadcast. Devices joining or rejoining during the first interval after startup therefore have no source-route table entry on the NCP and fall back to AODV/route discovery — the opposite of what enabling the concentrator is meant to achieve. WithMTOR_MAX_INTERVALcurrently at 3600s, that gap can be up to an hour.Per the SDK enum docs (
sl_zigbee_types.h/ember-types.h):zigbee-herdsman's ember adapter uses
RESCHEDULEfor this reason. Switch bellows to match.